From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Thu, 12 Jan 2012 14:57:24 +0000 Subject: Re: [PATCH] KVM: Move gfn_to_memslot() to kvm_host.h Message-Id: <4F0EF4D4.5030406@suse.de> List-Id: References: <20111220092102.GA5626@bloggs.ozlabs.ibm.com> <20120112104115.GA32021@bloggs.ozlabs.ibm.com> In-Reply-To: <20120112104115.GA32021@bloggs.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras Cc: linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Avi Kivity On 01/12/2012 11:41 AM, Paul Mackerras wrote: > This moves __gfn_to_memslot() and search_memslots() from kvm_main.c to > kvm_host.h to reduce the code duplication caused by the need for > non-modular code in arch/powerpc/kvm/book3s_hv_rm_mmu.c to call > gfn_to_memslot() in real mode. > > Rather than putting gfn_to_memslot() itself in a header, which would > lead to increased code size, this puts __gfn_to_memslot() in a header. > Then, the non-modular uses of gfn_to_memslot() are changed to call > __gfn_to_memslot() instead. This way there is only one place in the > source code that needs to be changed should the gfn_to_memslot() > implementation need to be modified. > > On powerpc, the Book3S HV style of KVM has code that is called from > real mode which needs to call gfn_to_memslot() and thus needs this. > (Module code is allocated in the vmalloc region, which can't be > accessed in real mode.) > > With this, we can remove builtin_gfn_to_memslot() from book3s_hv_rm_mmu.c. > > Signed-off-by: Paul Mackerras Confusing to review, but looks correct :). Avi, please ack. Alex