From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Date: Mon, 05 Mar 2012 18:10:59 +0000
Subject: Re: [PATCH] KVM: PPC: check error return of kvmppc_core_vcpu_create first
Message-Id: <4F5501B3.6050601@suse.de>
List-Id: <kvm-ppc.vger.kernel.org>
References: <50A8F108-8055-4115-B4EB-706D97736E65@ubuntu.com>
In-Reply-To: <50A8F108-8055-4115-B4EB-706D97736E65@ubuntu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Ben Collins <bcollins@ubuntu.com>
Cc: kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org

On 02/21/2012 05:30 AM, Ben Collins wrote:
> The result of kvmppc_core_vcpu_create() was being manipulated before it was checked for IS_ERR(). Did not see the bug occur, but caught it when looking through the code.

Nice catch, but this has already been fixed by Matt:

commit c6f3830e7313eea47b526b597aadc5b18c69ad55
Author: Matt Evans <matt@ozlabs.org>
Date:   Tue Dec 6 21:19:42 2011 +0000

     KVM: PPC: Fix vcpu_create dereference before validity check.

     Fix usage of vcpu struct before check that it's actually valid.

     Signed-off-by: Matt Evans <matt@ozlabs.org>
     Signed-off-by: Alexander Graf <agraf@suse.de>


Thanks a lot for sending the patch nevertheless!

Alex