From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Wed, 07 Mar 2012 13:53:58 +0000 Subject: Re: [PATCH 1/2] powerpc/e500: make load_up_spe a normal fuction Message-Id: <4F576876.8030807@suse.de> List-Id: References: <1330340388-30296-1-git-send-email-hong-hua.yin@freescale.com> <4F4BD726.1030805@freescale.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Yin Olivia-R63875 Cc: Wood Scott-B07421 , "kvm-ppc@vger.kernel.org" , "kvm@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Liu Yu-B13201 On 02/28/2012 08:09 AM, Yin Olivia-R63875 wrote: > Hi Scott, > > This had been reviewed before and accepted by internal tree. > http://linux.freescale.net/patchwork/patch/11100/ > http://git.am.freescale.net/gitolite/gitweb.cgi/sdk/kvm.git/commit/?h=3Df= or-sdk1.2&id=C5088844dc665dbdae4fa51b8d58dc203bacc17e > > I didn't change anything except the line. > I just commit to external kvm-ppc mailing list. Should I add my own Signe= d-off-by? Yes, if you just take a patch from someone else and direct it to another=20 tree, you keep the From: line (git cherry-pick or git am should do that=20 automatically for you) and add your own SOB-line (git am -s can do that=20 for example). Since you're also supposed to change the description, please note that=20 between Yu's SOB line and your SOB line with something like Signed-off-by: Liu Yu [olivia: change description] Signed-off-by: Olivia Yin Alex