From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Thu, 08 Mar 2012 18:20:15 +0000
Subject: Re: [PATCH] PPC: Don't sync timebase when inside VM
Message-Id: <4F58F85F.8090604@freescale.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1330697553-27156-1-git-send-email-agraf@suse.de> <20120302162058.GA24552@schlenkerla.am.freescale.net> <9A229F04-DFC9-485D-AB06-B1A4F0AEB348@suse.de> <4F5100A0.8040802@freescale.com> <CAEsOVNczPUdfUK6oZ7WOTGUQbA135HgrntwvnydbYd-Eo4joLg@mail.gmail.com>
In-Reply-To: <CAEsOVNczPUdfUK6oZ7WOTGUQbA135HgrntwvnydbYd-Eo4joLg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: McClintock Matthew-B29882 <B29882@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>, Alexander Graf <agraf@suse.de>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, kvm list <kvm@vger.kernel.org>, "<kvm-ppc@vger.kernel.org>" <kvm-ppc@vger.kernel.org>

On 03/08/2012 11:31 AM, McClintock Matthew-B29882 wrote:
> On Fri, Mar 2, 2012 at 11:17 AM, Scott Wood <scottwood@freescale.com> wrote:
>> On 03/02/2012 10:30 AM, Alexander Graf wrote:
>>>
>>> On 02.03.2012, at 17:20, Scott Wood wrote:
>>>> Again, for 85xx we should *never* sync the timebase in the kernel,
>>>> hypervisor or no.
>>>
>>> The code says "if the kexec config option is enabled, do the sync". I'm fairly sure it's there for a reason.
>>
>> Sigh.  I forgot about that.  It's because instead of doing kexec the
>> simple way, we actually physically reset the core.  We really shouldn't
>> do that.  And we *really* shouldn't do it just because CONFIG_KEXEC is
>> defined, regardless of whether we're actually booting from kexec.
> 
> How would one rocver a core that's off in the weeds? 

System reset?

I thought kexec was for upgrading your kernel, not recovering from crashes.

> We need to at least stop it somehow before we restart into the kdump kernel. kexec
> seems feasible since we have all the cores in a known state...

Stop, yes.  Reset, no.

-Scott