Re: Question about removing memslots

Avi Kivity
2012-03-29T15:26:59Z

On 03/29/2012 05:21 PM, Takuya Yoshikawa wrote:
> On Thu, 29 Mar 2012 11:44:12 +0200
> Avi Kivity <avi@redhat.com> wrote:
>
> > > Even without using reverse mapping we can restrict that flush easily:
> > >
> > > http://www.spinics.net/lists/kvm/msg68695.html
> > > [PATCH] KVM: Avoid zapping unrelated shadows in __kvm_set_memory_region()
> > >
> > > This would be better than using reverse mapping because we do not have so
> > > many shadow pages when we are in a tight loop like you mensioned.
> > >
> > > Anyway we could easily see tens of milliseconds difference by eliminating
> > > unrelated flush.
> >
> > Hm, the patch uses ->slot_bitmap which we might want to kill if we
> > increase the number of slots dramatically, as some people want to do.
> >
> > btw, what happened to that patch, did it just get ignored on the list?
>
> I did not get any comments, maybe because it was during around your vacation.

Care to refresh it? I think it's worthwhile.

And please ping me (or Marcelo, or others) if you get no reviews.

--
error compiling committee.c: too many arguments to function