From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Thu, 26 Apr 2012 21:54:37 +0000
Subject: Re: [PATCH 2/2] KVM: PPC: Book3S: Call into C interrupt handlers
Message-Id: <4F99C41D.8030204@freescale.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1335435543-19690-1-git-send-email-agraf@suse.de> <1335435543-19690-2-git-send-email-agraf@suse.de>
In-Reply-To: <1335435543-19690-2-git-send-email-agraf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Alexander Graf <agraf@suse.de>
Cc: kvm list <kvm@vger.kernel.org>, kvm-ppc <kvm-ppc@vger.kernel.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>

On 04/26/2012 05:19 AM, Alexander Graf wrote:
> +	asm("mfmsr %0" : "=r"(msr));

Why not just mfmsr()?

> +	asm("bl 1f; 1: mflr %0" : "=r"(ip));

You'll want to tell the compiler that you're trashing LR.

-Scott