From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: kvm-ppc@vger.kernel.org,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: [PATCH] pseries pci: removed dt_irq from PCI host bus
Date: Thu, 14 Jun 2012 04:36:42 +0000 [thread overview]
Message-ID: <4FD96A5A.5050605@ozlabs.ru> (raw)
As it is a very quick operation to resolve qirq from IRQ number,
it makes no sense to cache it anywhere but its original source i.e. XICS.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
hw/spapr_pci.c | 14 +++++---------
hw/spapr_pci.h | 1 -
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
index 269dbbf..93017cd 100644
--- a/hw/spapr_pci.c
+++ b/hw/spapr_pci.c
@@ -162,7 +162,9 @@ static void pci_spapr_set_irq(void *opaque, int irq_num, int level)
*/
sPAPRPHBState *phb = opaque;
- qemu_set_irq(phb->lsi_table[irq_num].qirq, level);
+ qemu_set_irq(xics_assign_irq(spapr->icp,
+ phb->lsi_table[irq_num].dt_irq, XICS_LSI),
+ level);
}
static uint64_t spapr_io_read(void *opaque, target_phys_addr_t addr,
@@ -268,16 +270,10 @@ static int spapr_phb_init(SysBusDevice *s)
/* Initialize the LSI table */
for (i = 0; i < PCI_NUM_PINS; i++) {
- qemu_irq qirq;
- uint32_t num;
-
- qirq = spapr_allocate_lsi(0, &num);
- if (!qirq) {
+ if (!spapr_allocate_lsi(0, &phb->lsi_table[i].dt_irq)) {
+ fprintf(stderr, "Failed to allocate LSI IRQ pin %u\n", i);
return -1;
}
-
- phb->lsi_table[i].dt_irq = num;
- phb->lsi_table[i].qirq = qirq;
}
return 0;
diff --git a/hw/spapr_pci.h b/hw/spapr_pci.h
index dd66f4b..11c3ee1 100644
--- a/hw/spapr_pci.h
+++ b/hw/spapr_pci.h
@@ -41,7 +41,6 @@ typedef struct sPAPRPHBState {
struct {
uint32_t dt_irq;
- qemu_irq qirq;
} lsi_table[PCI_NUM_PINS];
QLIST_ENTRY(sPAPRPHBState) list;
--
1.7.7.3
next reply other threads:[~2012-06-14 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 4:36 Alexey Kardashevskiy [this message]
2012-06-28 13:02 ` [PATCH] pseries pci: removed dt_irq from PCI host bus Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD96A5A.5050605@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox