From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Sun, 01 Jul 2012 07:41:05 +0000 Subject: Re: [PATCH 6/6] KVM: MMU: Avoid handling same rmap_pde in kvm_handle_hva_range() Message-Id: <4FEFFF11.4000309@redhat.com> List-Id: References: <20120628105733.ccd9abb3.yoshikawa.takuya@oss.ntt.co.jp> <20120628110235.7410445e.yoshikawa.takuya@oss.ntt.co.jp> <4FEC9A2B.6000104@redhat.com> <20120629104629.b369cd40.yoshikawa.takuya@oss.ntt.co.jp> In-Reply-To: <20120629104629.b369cd40.yoshikawa.takuya@oss.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Takuya Yoshikawa Cc: mtosatti@redhat.com, agraf@suse.de, paulus@samba.org, aarcange@redhat.com, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, takuya.yoshikawa@gmail.com On 06/29/2012 04:46 AM, Takuya Yoshikawa wrote: > On Thu, 28 Jun 2012 20:53:47 +0300 > Avi Kivity wrote: > >> > Note: in the new code we could not use trace_kvm_age_page(), so we just >> > dropped the point from kvm_handle_hva_range(). >> > >> >> Can't it be pushed to handler()? > > Yes, but it will be changed to print rmap, not hva and gfn. > I will do in the next version. We should try to avoid changing the tracepoint ABI. If we pass the memslot to handler(), we should be able to reconstruct the gfn and hva. -- error compiling committee.c: too many arguments to function