From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 06 May 2014 06:57:51 +0000 Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr Message-Id: <536887EF.2070201@suse.de> List-Id: References: <1399224075-18041-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <536773C2.1070502@suse.de> <20140506004133.GA12595@iris.ozlabs.ibm.com> In-Reply-To: <20140506004133.GA12595@iris.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, "Aneesh Kumar K.V" , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On 06.05.14 02:41, Paul Mackerras wrote: > On Mon, May 05, 2014 at 01:19:30PM +0200, Alexander Graf wrote: >> On 05/04/2014 07:21 PM, Aneesh Kumar K.V wrote: >>> +#ifdef CONFIG_PPC_BOOK3S_64 >>> + return vcpu->arch.fault_dar; >> How about PA6T and G5s? > G5 sets DAR on an alignment interrupt. > > As for PA6T, I don't know for sure, but if it doesn't, ordinary > alignment interrupts wouldn't be handled properly, since the code in > arch/powerpc/kernel/align.c assumes DAR contains the address being > accessed on all PowerPC CPUs. Now that's a good point. If we simply behave like Linux, I'm fine. This definitely deserves a comment on the #ifdef in the code. Alex