From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 20 May 2014 11:21:11 +0000 Subject: Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO Message-Id: <537B3AA7.7040106@suse.de> List-Id: References: <1400574612-19411-1-git-send-email-gwshan@linux.vnet.ibm.com> <1400574612-19411-4-git-send-email-gwshan@linux.vnet.ibm.com> In-Reply-To: <1400574612-19411-4-git-send-email-gwshan@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Gavin Shan , kvm-ppc@vger.kernel.org Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org On 20.05.14 10:30, Gavin Shan wrote: > The patch adds new IOCTL command VFIO_EEH_OP to VFIO PCI device > to support EEH functionality for PCI devices, which have been > passed from host to guest via VFIO. > > Signed-off-by: Gavin Shan > --- > arch/powerpc/platforms/powernv/Makefile | 1 + > arch/powerpc/platforms/powernv/eeh-vfio.c | 445 ++++++++++++++++++++++++++++++ > drivers/vfio/pci/vfio_pci.c | 24 +- > drivers/vfio/pci/vfio_pci_private.h | 16 ++ > include/uapi/linux/vfio.h | 43 +++ > 5 files changed, 523 insertions(+), 6 deletions(-) > create mode 100644 arch/powerpc/platforms/powernv/eeh-vfio.c Why doesn't this code live inside the vfio module? If I don't load the vfio module, I don't need that code to waste memory in my kernel, no? Alex