From: Alexander Graf <agraf@suse.de>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 6/6] kvm: ppc: Add SPRN_SPR get helper function
Date: Thu, 17 Jul 2014 08:17:51 +0000 [thread overview]
Message-ID: <53C786AF.408@suse.de> (raw)
In-Reply-To: <1405407692-32075-7-git-send-email-Bharat.Bhushan@freescale.com>
On 16.07.14 06:21, Bharat.Bhushan@freescale.com wrote:
>
>> -----Original Message-----
>> From: Caraman Mihai Claudiu-B02008
>> Sent: Tuesday, July 15, 2014 10:20 PM
>> To: Alexander Graf
>> Cc: Bhushan Bharat-R65777; kvm-ppc@vger.kernel.org
>> Subject: Re: [PATCH 6/6] kvm: ppc: Add SPRN_SPR get helper function
>>
>>> kvmppc_set_epr() is already defined in asm/kvm_ppc.h, So
>>> rename and move get_epr helper function to same file.
>>>
>>> Signed-off-by: Bharat Bhushan <Bharat.Bhushan@freescale.com>
>>> ---
>>> arch/powerpc/include/asm/kvm_ppc.h | 9 +++++++++
>>> arch/powerpc/kvm/booke.c | 11 +----------
>>> 2 files changed, 10 insertions(+), 10 deletions(-)
>> This patch which is already applied on kvm-ppc-queue breaks book3s.
>> I get these errors with g5_defconfig:
>>
>> In file included from arch/powerpc/kernel/asm-offsets.c:57:0:
>> ./arch/powerpc/include/asm/kvm_ppc.h: In function 'kvmppc_get_epr':
>> ./arch/powerpc/include/asm/kvm_ppc.h:400:19: error: 'struct kvm_vcpu_arch' has
>> no member named 'epr'
>> ./arch/powerpc/include/asm/kvm_ppc.h: In function 'kvmppc_get_sprg0':
>> ./arch/powerpc/include/asm/kvm_ppc.h:522:1: error: 'SPRN_GSPRG0' undeclared
>> (first use in this function)
>> ./arch/powerpc/include/asm/kvm_ppc.h:522:1: note: each undeclared identifier is
>> reported only once for each function it appears in
>> ...
> I am sorry, I forgot to compile for book3s.
>
> Should we squash below change to fix these errors.
While trying to squash them in I realized that things become very ugly
here. If we have to explicitly #ifdef the generators, why don't we just
call a new macro for the SPRN_G access and #ifdef on CONFIG_KVM_BOOKE_HV?
#ifdef CONFIG_KVM_BOOKE_HV
SPRNG_WRAPPER(sprg0, SPRN_GSPRG0)
...
#else
SHARED_WRAPPER(sprg0, SPRN_GSPRG0)
#endif
that way the code flow is at least reasonably obvious :). I'll remove
the patches from my queue for now.
Alex
next prev parent reply other threads:[~2014-07-17 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405407692-32075-1-git-send-email-Bharat.Bhushan@freescale.com>
2014-07-15 7:13 ` [PATCH 1/6] kvm: ppc: booke: Enhance wrapper functions to handle shadow registers Bharat Bhushan
2014-07-15 7:13 ` [PATCH 2/6] kvm: ppc: booke: Use the shared struct helpers of SRR0 and SRR1 Bharat Bhushan
2014-07-15 7:13 ` [PATCH 3/6] kvm: ppc: booke: Use the shared struct helpers of SPRN_DEAR Bharat Bhushan
2014-07-15 7:13 ` [PATCH 4/6] kvm: ppc: booke: Add shared struct helpers of SPRN_ESR Bharat Bhushan
2014-07-15 7:13 ` [PATCH 5/6] kvm: ppc: booke: Use the shared struct helpers for SPRN_SPRG0-7 Bharat Bhushan
2014-07-15 7:13 ` [PATCH 6/6] kvm: ppc: Add SPRN_SPR get helper function Bharat Bhushan
2014-07-15 16:50 ` mihai.caraman
2014-07-16 4:21 ` Bharat.Bhushan
2014-07-17 8:17 ` Alexander Graf [this message]
2014-07-15 11:52 ` [PATCH 0/6] Cleanup and fixes related to helper SPRN_XX functions Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C786AF.408@suse.de \
--to=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox