From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Qiu Date: Tue, 22 Jul 2014 03:10:42 +0000 Subject: Re: [PATCH v1 2/3] powerpc/powernv: Support PCI error injection Message-Id: <53CDD632.1050908@linux.vnet.ibm.com> List-Id: References: <1403489682-14841-1-git-send-email-gwshan@linux.vnet.ibm.com> <1403489682-14841-3-git-send-email-gwshan@linux.vnet.ibm.com> <53A91819.1010900@linux.vnet.ibm.com> <1403591761.4587.161.camel@pasglop> <53A9216C.8050904@linux.vnet.ibm.com> <1403593252.4587.163.camel@pasglop> <20140625000305.GA5742@shangw> <53AA3C5C.4080807@linux.vnet.ibm.com> <1403666349.4587.196.camel@pasglop> <53CCCA09.1060404@linux.vnet.ibm.com> <1405982949.5289.217.camel@pasglop> In-Reply-To: <1405982949.5289.217.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Benjamin Herrenschmidt Cc: aik@ozlabs.ru, linuxppc-dev@lists.ozlabs.org, Gavin Shan , kvm-ppc@vger.kernel.org, agraf@suse.de On 07/22/2014 06:49 AM, Benjamin Herrenschmidt wrote: > On Mon, 2014-07-21 at 16:06 +0800, Mike Qiu wrote: >>> I don't like this. I much prefer have dedicated error injection files >>> in their respective locations, something for PCI under the corresponding >>> PCI bridge etc... >> So PowerNV error injection will be designed rely on debugfs been >> configured, right? > Not necessarily. If we create a better debugfs layout for our PHBs, then > yes. It might be useful to provide more info in there for example access > to some of the counters ... > > But on the other hand, for error injection in general, I wonder if we should > be under sysfs instead... something to study a bit. In pHyp, general error injection use syscall: #define __NR_rtas 255 I don't know if it is a good idea to reuse this syscall for PowerNV. At least, it is another choice without sysfs rely. Thanks, Mike > > Cheers, > Ben. > > >