From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 07 Aug 2015 13:59:28 +0000
Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing
Message-Id: <55C4B9C0.5030102@redhat.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1438955228-30116-1-git-send-email-xerofoify@gmail.com>
In-Reply-To: <1438955228-30116-1-git-send-email-xerofoify@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Nicholas Krause <xerofoify@gmail.com>, agraf@suse.com
Cc: gleb@kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org



On 07/08/2015 15:47, Nicholas Krause wrote:
> -	kvm_set_irq_routing(opp->kvm, routing, 0, 0);
> +	ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
> +	if (ret) {
> +		kfree(routing);
> +		return ret;
> +	}
>  
>  	kfree(routing);
>  	return 0;

You could just return ret here.  The new "if" is not necessary.

Paolo