From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, dgibson@redhat.com,
pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls
Date: Tue, 01 Mar 2016 13:13:43 +0000 [thread overview]
Message-ID: <56D59587.3010209@redhat.com> (raw)
In-Reply-To: <20160301122740.smg5c6qxaonf5kpt@hawk.localdomain>
On 01.03.2016 13:27, Andrew Jones wrote:
> On Tue, Mar 01, 2016 at 01:06:11PM +0100, Thomas Huth wrote:
>> On 01.03.2016 12:51, Laurent Vivier wrote:
>>>
>>> On 01/03/2016 11:08, Thomas Huth wrote:
>>>> Introduce a test for sPAPR hypercalls, starting with the
>>>> three hypercalls H_SET_SPRG0, H_PAGE_INIT and H_RANDOM.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
...
>>> Is it possible to have a message for the H_RANDOM test, something like
>>> "not supported"?
>>
>> I initially had something like that in my code, but the output like
>>
>> PASS: hypercall: h_random: not supported
>>
>> then also looks somewhat strange ...
>>
>> Is there already a common sense how to (not) report missing and thus
>> untestable features in kvm-unit-tests? Something like
>>
>> SKIP: hypercall: h_random: not supported
>>
>> would be posh, I think...
>
> We have XFAIL (instead of SKIP). So you could maybe do something like
>
> report_xfail(fmt, !is_supported, test_passed, ...)
Ah, that looks fine, thanks for the hint, I'll change my patch to use it!
Thomas
next prev parent reply other threads:[~2016-03-01 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 10:08 [kvm-unit-tests PATCH v2] powerpc: Add tests for sPAPR h-calls Thomas Huth
2016-03-01 11:51 ` Laurent Vivier
2016-03-01 12:06 ` Thomas Huth
2016-03-01 12:27 ` Andrew Jones
2016-03-01 13:13 ` Thomas Huth [this message]
2016-03-01 13:23 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D59587.3010209@redhat.com \
--to=thuth@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox