From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Date: Wed, 02 Mar 2016 10:33:19 +0000 Subject: Re: [PATCH v3] powerpc: Add tests for sPAPR h-calls Message-Id: <56D6C16F.7060407@redhat.com> List-Id: References: <1456908043-11184-1-git-send-email-thuth@redhat.com> <56D6BB7B.70401@redhat.com> <56D6BEDE.7030403@redhat.com> In-Reply-To: <56D6BEDE.7030403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paolo Bonzini , Thomas Huth , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com Cc: dgibson@redhat.com On 02/03/2016 11:22, Paolo Bonzini wrote: > > > On 02/03/2016 11:07, Laurent Vivier wrote: >>>> + report_xfail("h-call available", rc = H_FUNCTION, rc = H_SUCCESS); >>>> + if (rc != H_SUCCESS) >>>> + return; >> I think it can be disturbing to not always have the same number of >> tests, so remove the initial checking and use the report_xfail on the >> following report. >> >> > > It's actually fairly common, see for example x86/apic and x86/xsave tests. OK, so you can add my Reviewed-by: Laurent Vivier to this patch (the other comment about asm() doesn't worth a re-spin) Laurent