From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 03 Mar 2016 17:12:06 +0000
Subject: Re: [kvm-unit-tests PATCH] powerpc: Add tests for RTAS
Message-Id: <56D87066.1090205@redhat.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <1457008099-29944-1-git-send-email-lvivier@redhat.com>
 <20160303160309.GC2354@potion.brq.redhat.com> <56D8666A.40508@redhat.com>
 <20160303170912.GD2354@potion.brq.redhat.com>
In-Reply-To: <20160303170912.GD2354@potion.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com, thuth@redhat.com, dgibson@redhat.com



On 03/03/2016 18:09, Radim Krčmář wrote:
>>>>> >>> > +	/* compute epoch: substract DAYS(since_March(1-1-1970)) */
>>>>> >>> > +	epoch = DAYS(year, month, day) - DAYS(1969, 11, 1);
> And this comment points out that the API is bad. :)
> 
> (Btw. am I going overboard?)

Only because I've committed it already. ;)

Paolo