From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Date: Mon, 21 Mar 2016 15:59:43 +0000 Subject: Re: [kvm-unit-tests PATCH v2 4/5] powerpc: check lswx Message-Id: <56F01A6F.7020002@redhat.com> List-Id: References: <1458560014-28862-1-git-send-email-lvivier@redhat.com> <1458560014-28862-5-git-send-email-lvivier@redhat.com> <56EFE3EA.5000900@redhat.com> <56F00471.6070801@redhat.com> In-Reply-To: <56F00471.6070801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paolo Bonzini , Thomas Huth , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org Cc: drjones@redhat.com, dgibson@redhat.com On 21/03/2016 15:25, Paolo Bonzini wrote: > > > On 21/03/2016 13:07, Thomas Huth wrote: >>>> + /* adding r1 in the clobber list doesn't protect it... */ >> You repeat that again in the comment below, so in case you respin this >> series, you could also drop one of the two comments, I think. > > I can do it while fixing the typo (arount->around). Yes, please. Thanks, Laurent > > Paolo > >>>> + "mr r29,r1;" >>>> + "li r31,-1;" >>>> + "mr r1,r31;" >>>> + "mr r0, %[addr];" >>>> + "lswx r31, 0, r0;" >>>> + "std r31, 0*8(%[regs]);" >>>> + "std r0, 1*8(%[regs]);" >>>> + "std r1, 2*8(%[regs]);" >>>> + "mr r1,r29;" >>>> + :: >>>> + [len] "r" (12), >>>> + [addr] "r" (addr), >>>> + [regs] "r" (regs) >>>> + : >>>> + /* three registers from r31, wrap arount to r1,