From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Date: Tue, 22 Mar 2016 08:12:31 +0000 Subject: Re: [kvm-unit-tests PATCH v2 5/5] powerpc: Check lswx in little-endian mode. Message-Id: <56F0FE6F.8010501@redhat.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="BePSLuLEG2jQsR0gMK4KjgtSTIwUiinDh" List-Id: References: <1458560014-28862-1-git-send-email-lvivier@redhat.com> <1458560014-28862-6-git-send-email-lvivier@redhat.com> <20160322105609.1bed546e@voom.fritz.box> In-Reply-To: <20160322105609.1bed546e@voom.fritz.box> To: David Gibson , Laurent Vivier Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BePSLuLEG2jQsR0gMK4KjgtSTIwUiinDh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 22.03.2016 00:56, David Gibson wrote: > On Mon, 21 Mar 2016 12:33:34 +0100 > Laurent Vivier wrote: >=20 >> For lswx in little-endian mode, an alignment interrupt occurs. >> >> Signed-off-by: Laurent Vivier >> Reviewed-by: Thomas Huth >=20 > I'm not entirely clear here; will the test fail if the alignment > exception doesn't occur in little endian mode? I think so, yes. > The general trend in Power has been for less and less things to trigger= > alignment exceptions, so failing to cause an alignment exception > shouldn't cause a test failure (as long as the unaligned case is > correctly processed, of course). According to the PowerISA 2.07, chapter 6.5.8, lswx should always trigger an alignment exception in little endian mode. So that's architected behavior and the test should be OK, as far as I can see... In case this gets changed with a future CPU, I think the test could be adapted later, too? Thomas --BePSLuLEG2jQsR0gMK4KjgtSTIwUiinDh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJW8P50AAoJEC7Z13T+cC21UIcQAKuDA6s2VGRqQz09F+fzf4MA CAzIc8H3uDmkf0E9KNBlCpMWrpyRpDIszTnFXCr15H48nHlDPePc1ovjePOjwiWf iBPs+xDy0uToldR6DhrrdpkJykaD8SLGhXaIWo0dqRxwzoHvnbhy310eMzmOeZgD m0qoPAmj/KgioKSWQmQW/XNydeG9Yne/YDYGofezutehOssxp0Ax2F2DV6UoreUp a2ejr62mZXfN8/JvsZO84oqkIdkiWJgq86hKSJMEFO7yyI8Qg5UVUp6TEhvD3N2U sDW0DanOj1FbHeVo+qQjJ7LgSIPJdRnD7jbGhDYvDxL7mVz27ZXLXyTnOuDPYALm r1cGxzVs2tubd8JNbdoYZSaV4sM9pr7SnwAWGLO86hgj9iYK0XGWlNSghVzF0Kun zOdV+U9CoBeTXwL0nl21iqK2KYH9Y/bW1lhxo/e7KhVdeXqYBiXDh5giCG8GUnRb Wxq1pZ6F5WKcYtjFgKAlrQK2yn4OYtsFPldKrc/+vSTBqLaZQxqorquePOYEhB2R TiaUxKpHM8LFjICqzqPvyF8mPF4UlR7jGtZ0JEBx4oI2IiwhXBNer1dW6rrjGUwC 8jYaBWcqLuJNtTiagvqhEL199T417uEqCZ77fMQZ5wz5kv9tgJWfhewjppKKI1t6 NCPpQm6+SQ4zD9PkHXee =Up32 -----END PGP SIGNATURE----- --BePSLuLEG2jQsR0gMK4KjgtSTIwUiinDh--