From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leonardo Bras <leonardo@linux.ibm.com>
Date: Tue, 24 Sep 2019 13:46:19 +0000
Subject: Re: [PATCH 0/3] Replace current->mm by kvm->mm on powerpc/kvm
Message-Id: <77a2a670b900dcde3e4d88094d5d04752db27b86.camel@linux.ibm.com>
MIME-Version: 1
Content-Type: multipart/mixed; boundary="=-2jqimbQY+p+IkhB2VQWm"
List-Id: <kvm-ppc.vger.kernel.org>
References: <20190923212409.7153-1-leonardo@linux.ibm.com>
         <20190924020008.GA4011@oak.ozlabs.ibm.com>
In-Reply-To: <20190924020008.GA4011@oak.ozlabs.ibm.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Michael Ellerman <mpe@ellerman.id.au>


--=-2jqimbQY+p+IkhB2VQWm
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2019-09-24 at 12:00 +1000, Paul Mackerras wrote:
> On Mon, Sep 23, 2019 at 06:24:06PM -0300, Leonardo Bras wrote:
> > By replacing, we would reduce the use of 'global' current on code,
> > relying more in the contents of kvm struct.
> >=20
> > On code, I found that in kvm_create_vm() there is:
> > kvm->mm =3D current->mm;
> >=20
> > And that on every kvm_*_ioctl we have tests like that:
> > if (kvm->mm !=3D current->mm)
> >         return -EIO;
> >=20
> > So this change would be safe.
> >=20
> > I split the changes in 3 patches, so it would be easier to read
> > and reject separated parts. If decided that squashing is better,
> > I see no problem doing that.
>=20
> The patch series looks fine.  It has missed the 5.4 merge window, and
> it doesn't fix any bugs, so I will queue it up for the 5.5 merge
> window, meaning that I will put it into my kvm-ppc-next branch when I
> prepare it for the 5.5 merge window, probably in about a month from
> now.
>=20
> This remark also applies to your other patch "Reduce calls to get
> current->mm by storing the value locally".
>=20
> Thanks,
> Paul.

Thanks!
Leonardo Bras

--=-2jqimbQY+p+IkhB2VQWm
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl2KHisACgkQlQYWtz9S
ttQIfA/9G1Z3gXIzBuQy/Li1ffXn/K6+pga8zrZXxcXGnu3on0Qze5Z3sE4EKhhG
w+BjJ2ir+JBsExKPpyAtO8AaBHk2TjeCxUha0z0g4o5QQ2wz62FRxTXv2u3MwR/4
q8KqRuIdWd5lVAJ0YG7cR0NR/ICfoOErsX2uYRCMwFgHxkh9yjy63GrCaTZNQA+o
YXBlqP/FfdEOI5OceveW7YZoNLGUuXgXXj/vWYY/+ry6yX46ctcwTCpboeOoc0uN
lSupIJrX+jYULmH4pKlGqwWnanolzJ4oHV/zmVdqB+O0vU42EPPPymLB2Uh0USdw
RY9wbKSxdqj074uPECr/mEMJCpFcvtRaRITG25V27b0KCn7u2GQPEt8cuKAXPCoa
qlPyRMTtOFmLRrn5piFUrgXHYaIFtQCfWqUZ+prKK39Sbwugu9NMbrwABoCAVS3y
vGywSZAukwlqgEYtaJsx2TlScMz92Pryze14HHxl4hDR5jtWWosAwtNxnjLm1tyQ
QQBrD19Vh5g6XPUlf8ekSEBvLf0XKKMeQWNrJwUtWED26jnNCF1ux0xfaCbMkLif
nV1w/WJQzH3fhxIptL8c2NnBDnLF1JE4bBaSs6sKeFcU2NFjx/a/RsitLLF/PHKP
cvlBqahmGrl72efAnKyXHMrrGj2zl0AXoGcBI7uwGq2GMlQu0bw=
=zz1z
-----END PGP SIGNATURE-----

--=-2jqimbQY+p+IkhB2VQWm--