From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabiano Rosas Date: Fri, 06 Aug 2021 20:46:36 +0000 Subject: Re: [PATCH v1 31/55] KVM: PPC: Book3S HV P9: Juggle SPR switching around Message-Id: <8735rmti6r.fsf@linux.ibm.com> List-Id: References: <20210726035036.739609-1-npiggin@gmail.com> <20210726035036.739609-32-npiggin@gmail.com> In-Reply-To: <20210726035036.739609-32-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nicholas Piggin , kvm-ppc@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, Nicholas Piggin Nicholas Piggin writes: > This juggles SPR switching on the entry and exit sides to be more > symmetric, which makes the next refactoring patch possible with no > functional change. > > Signed-off-by: Nicholas Piggin Reviewed-by: Fabiano Rosas > --- > arch/powerpc/kvm/book3s_hv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 56429b53f4dc..c2c72875fca9 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -4175,7 +4175,7 @@ static int kvmhv_p9_guest_entry(struct kvm_vcpu *vcpu, u64 time_limit, > msr = mfmsr(); /* TM restore can update msr */ > } > > - switch_pmu_to_guest(vcpu, &host_os_sprs); > + load_spr_state(vcpu, &host_os_sprs); > > load_fp_state(&vcpu->arch.fp); > #ifdef CONFIG_ALTIVEC > @@ -4183,7 +4183,7 @@ static int kvmhv_p9_guest_entry(struct kvm_vcpu *vcpu, u64 time_limit, > #endif > mtspr(SPRN_VRSAVE, vcpu->arch.vrsave); > > - load_spr_state(vcpu, &host_os_sprs); > + switch_pmu_to_guest(vcpu, &host_os_sprs); > > if (kvmhv_on_pseries()) { > /* > @@ -4283,6 +4283,8 @@ static int kvmhv_p9_guest_entry(struct kvm_vcpu *vcpu, u64 time_limit, > vcpu->arch.slb_max = 0; > } > > + switch_pmu_to_host(vcpu, &host_os_sprs); > + > store_spr_state(vcpu); > > store_fp_state(&vcpu->arch.fp); > @@ -4297,8 +4299,6 @@ static int kvmhv_p9_guest_entry(struct kvm_vcpu *vcpu, u64 time_limit, > > vcpu_vpa_increment_dispatch(vcpu); > > - switch_pmu_to_host(vcpu, &host_os_sprs); > - > timer_rearm_host_dec(*tb); > > restore_p9_host_os_sprs(vcpu, &host_os_sprs);