From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Wed, 09 Jun 2021 15:47:29 +0000 Subject: Re: [kvm-unit-tests PATCH v2 4/7] arm: unify header guards Message-Id: <874ke711m6.fsf@redhat.com> List-Id: References: <20210609143712.60933-1-cohuck@redhat.com> <20210609143712.60933-5-cohuck@redhat.com> <8399161a-ef26-7d4f-19fb-c54ca40fe6c3@redhat.com> In-Reply-To: <8399161a-ef26-7d4f-19fb-c54ca40fe6c3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Vivier , Paolo Bonzini , Thomas Huth , Andrew Jones Cc: kvm@vger.kernel.org, David Hildenbrand , Janosch Frank , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org On Wed, Jun 09 2021, Laurent Vivier wrote: > On 09/06/2021 16:37, Cornelia Huck wrote: >> The assembler.h files were the only ones not already following >> the convention. >> >> Signed-off-by: Cornelia Huck >> --- >> lib/arm/asm/assembler.h | 6 +++--- >> lib/arm64/asm/assembler.h | 6 +++--- >> 2 files changed, 6 insertions(+), 6 deletions(-) > > What about lib/arm/io.h? It didn't have a guard yet, so I didn't touch it. > > I think you can remove the guard from > > lib/arm/asm/memory_areas.h > > as the other files including directly a header doesn't guard it. I see other architectures doing that, though. I guess it doesn't hurt, but we can certainly also remove it. Other opinions? > > Missing lib/arm/asm/mmu-api.h, lib/arm/asm/mmu.h, lib/arm64/asm/mmu.h Oops, overlooked the extra underscore there.