From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Date: Mon, 23 Mar 2020 12:48:41 +0000 Subject: Re: [PATCH v3 9/9] KVM: SVM: Annotate svm_x86_ops as __initdata Message-Id: <874kuf9qza.fsf@vitty.brq.redhat.com> List-Id: References: <20200321202603.19355-1-sean.j.christopherson@intel.com> <20200321202603.19355-10-sean.j.christopherson@intel.com> In-Reply-To: <20200321202603.19355-10-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson , Paolo Bonzini Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Sean Christopherson writes: > Tag svm_x86_ops with __initdata now the the struct is copied by value to Same typo, "now that the struct". > a common x86 instance of kvm_x86_ops as part of kvm_init(). > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index b61bb306602b..ab2a1cf6c188 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -7350,7 +7350,7 @@ static void svm_pre_update_apicv_exec_ctrl(struct kvm *kvm, bool activate) > avic_update_access_page(kvm, activate); > } > > -static struct kvm_x86_ops svm_x86_ops __ro_after_init = { > +static struct kvm_x86_ops svm_x86_ops __initdata = { > .hardware_unsetup = svm_hardware_teardown, > .hardware_enable = svm_hardware_enable, > .hardware_disable = svm_hardware_disable, Reviewed-by: Vitaly Kuznetsov -- Vitaly