From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Axtens Date: Fri, 26 Feb 2021 05:21:50 +0000 Subject: Re: [PATCH v2 02/37] KVM: PPC: Book3S HV: Fix CONFIG_SPAPR_TCE_IOMMU=n default hcalls Message-Id: <875z2f9zf5.fsf@linkitivity.dja.id.au> List-Id: References: <20210225134652.2127648-1-npiggin@gmail.com> <20210225134652.2127648-3-npiggin@gmail.com> In-Reply-To: <20210225134652.2127648-3-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nicholas Piggin , kvm-ppc@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, Nicholas Piggin Hi Nick, > This config option causes the warning in init_default_hcalls to fire > because the TCE handlers are in the default hcall list but not > implemented. I checked that the TCE handlers are indeed not defined unless CONFIG_SPAPR_TCE_IOMMU=y, and so I can see how you would hit the warning. This seems like the right solution to me. Reviewed-by: Daniel Axtens Kind regards, Daniel > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/kvm/book3s_hv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 13bad6bf4c95..895090636295 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -5369,8 +5369,10 @@ static unsigned int default_hcall_list[] = { > H_READ, > H_PROTECT, > H_BULK_REMOVE, > +#ifdef CONFIG_SPAPR_TCE_IOMMU > H_GET_TCE, > H_PUT_TCE, > +#endif > H_SET_DABR, > H_SET_XDABR, > H_CEDE, > -- > 2.23.0