From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Wed, 09 Jun 2021 15:37:49 +0000 Subject: Re: [kvm-unit-tests PATCH v2 2/7] lib: unify header guards Message-Id: <877dj3122a.fsf@redhat.com> List-Id: References: <20210609143712.60933-1-cohuck@redhat.com> <20210609143712.60933-3-cohuck@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Vivier , Paolo Bonzini , Thomas Huth , Andrew Jones Cc: kvm@vger.kernel.org, David Hildenbrand , Janosch Frank , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org On Wed, Jun 09 2021, Laurent Vivier wrote: > On 09/06/2021 16:37, Cornelia Huck wrote: >> Standardize header guards to _LIB_HEADER_H_. >> >> Signed-off-by: Cornelia Huck >> --- >> lib/alloc_page.h | 4 ++-- >> lib/libcflat.h | 4 ++-- >> lib/list.h | 4 ++-- >> lib/pci-edu.h | 4 ++-- >> lib/pci-host-generic.h | 4 ++-- >> lib/setjmp.h | 4 ++-- >> lib/string.h | 6 +++--- >> lib/vmalloc.h | 4 ++-- >> 8 files changed, 17 insertions(+), 17 deletions(-) > > What about lib/argv.h and lib/pci.h? argv.h does not have a header guard yet (it probably should?) I forgot to commit my changes to pci.h, I think :( > > And there is also this instance of CONFIG_H in lib/config.h generated > by configure. Yeah, we should tweak the generator for that.