From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Date: Tue, 10 Dec 2013 16:20:14 +0000 Subject: Re: [PATCH] KVM: PPC: Use schedule instead of cond_resched Message-Id: <877gbcsn81.fsf@linux.vnet.ibm.com> List-Id: References: <1386685284-3862-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Ben Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, "kvm@vger.kernel.org mailing list" Alexander Graf writes: > On 10.12.2013, at 15:21, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" >> >> We already checked need_resched. So we can call schedule directly >> >> Signed-off-by: Aneesh Kumar K.V > > The real fix for the issue you're seeing is > > https://lkml.org/lkml/2013/11/28/241 True, I mentioned that in the thread https://lkml.org/lkml/2013/12/9/64 But do we need to do cond_resched after we checked for need_resched() ? -aneesh