From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabiano Rosas Date: Fri, 06 Aug 2021 14:53:06 +0000 Subject: Re: [PATCH kernel v2] KVM: PPC: Use arch_get_random_seed_long instead of powernv variant Message-Id: <87bl6atyjx.fsf@linux.ibm.com> List-Id: References: <20210805075649.2086567-1-aik@ozlabs.ru> In-Reply-To: <20210805075649.2086567-1-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org Cc: Alexey Kardashevskiy , kvm-ppc@vger.kernel.org, Michael Ellerman , kvm@vger.kernel.org Alexey Kardashevskiy writes: > The powernv_get_random_long() does not work in nested KVM (which is > pseries) and produces a crash when accessing in_be64(rng->regs) in > powernv_get_random_long(). > > This replaces powernv_get_random_long with the ppc_md machine hook > wrapper. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Fabiano Rosas > --- > > Changes: > v2: > * replaces [PATCH kernel] powerpc/powernv: Check if powernv_rng is initialized > > --- > arch/powerpc/kvm/book3s_hv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index be0cde26f156..ecfd133e0ca8 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -1165,7 +1165,7 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu) > break; > #endif > case H_RANDOM: > - if (!powernv_get_random_long(&vcpu->arch.regs.gpr[4])) > + if (!arch_get_random_seed_long(&vcpu->arch.regs.gpr[4])) > ret = H_HARDWARE; > break; > case H_RPT_INVALIDATE: