From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <maz@kernel.org>
Date: Fri, 30 Apr 2021 12:07:19 +0000
Subject: Re: [PATCH v4 1/4] KVM: stats: Separate common stats from architecture specific ones
Message-Id: <87bl9wnfgo.wl-maz@kernel.org>
List-Id: <kvm-ppc.vger.kernel.org>
References: <20210429203740.1935629-1-jingzhangos@google.com>
        <20210429203740.1935629-2-jingzhangos@google.com>
In-Reply-To: <20210429203740.1935629-2-jingzhangos@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Jing Zhang <jingzhangos@google.com>
Cc: KVM <kvm@vger.kernel.org>, KVMARM <kvmarm@lists.cs.columbia.edu>, LinuxMIPS <linux-mips@vger.kernel.org>, KVMPPC <kvm-ppc@vger.kernel.org>, LinuxS390 <linux-s390@vger.kernel.org>, Linuxkselftest <linux-kselftest@vger.kernel.org>, Paolo Bonzini <pbonzini@redhat.com>, James Morse <james.morse@arm.com>, Julien Thierry <julien.thierry.kdev@gmail.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Will Deacon <will@kernel.org>, Huacai Chen <chenhuacai@kernel.org>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Paul Mackerras <paulus@ozlabs.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Janosch Frank <frankja@linux.ibm.com>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Claudio Imbrenda <imbrenda@linux.ibm.com>, Sean Christopherson <seanjc@google.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, Jim Mattson <jmattson@google.com>, Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>, David Rientjes <rientjes@google.com>, Emanuele Giuseppe Esposito <eesposit@redhat.com>

On Thu, 29 Apr 2021 21:37:37 +0100,
Jing Zhang <jingzhangos@google.com> wrote:

> +struct kvm_vm_stat_common {
> +	ulong remote_tlb_flush;
> +};
> +
> +struct kvm_vcpu_stat_common {
> +	u64 halt_successful_poll;
> +	u64 halt_attempted_poll;
> +	u64 halt_poll_invalid;
> +	u64 halt_wakeup;
> +	u64 halt_poll_success_ns;
> +	u64 halt_poll_fail_ns;
> +};

Why can't we make everything a u64? Is there anything that really
needs to be a ulong? On most architectures, they are the same anyway,
so we might as well bite the bullet.

	M.

-- 
Without deviation from the norm, progress is not possible.