From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Date: Mon, 20 Jan 2014 15:34:07 +0000 Subject: Re: [PATCH 2/4] powernv: kvm: make _PAGE_NUMA take effect Message-Id: <87fvoi7k68.fsf@linux.vnet.ibm.com> List-Id: References: <1386751674-14136-1-git-send-email-pingfank@linux.vnet.ibm.com> <1386751674-14136-3-git-send-email-pingfank@linux.vnet.ibm.com> In-Reply-To: <1386751674-14136-3-git-send-email-pingfank@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Liu Ping Fan , linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org Cc: Paul Mackerras , Alexander Graf Liu Ping Fan writes: > To make _PAGE_NUMA take effect, we should force the checking when > guest uses hypercall to setup hpte. > > Signed-off-by: Liu Ping Fan > --- > arch/powerpc/kvm/book3s_hv_rm_mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_rm_mmu.c b/arch/powerpc/kvm/book3s_hv_rm_mmu.c > index 9c51544..af8602d 100644 > --- a/arch/powerpc/kvm/book3s_hv_rm_mmu.c > +++ b/arch/powerpc/kvm/book3s_hv_rm_mmu.c > @@ -232,7 +232,7 @@ long kvmppc_do_h_enter(struct kvm *kvm, unsigned long flags, > /* Look up the Linux PTE for the backing page */ > pte_size = psize; > pte = lookup_linux_pte(pgdir, hva, writing, &pte_size); > - if (pte_present(pte)) { > + if (pte_present(pte) && !pte_numa(pte)) { > if (writing && !pte_write(pte)) > /* make the actual HPTE be read-only */ > ptel = hpte_make_readonly(ptel); How did we end up doing h_enter on a pte entry with pte_numa bit set ? -aneesh