kvm-ppc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vaibhav Jain <vaibhav@linux.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com,
	aneesh.kumar@linux.ibm.com, Greg Kurz <groug@kaod.org>,
	kvm-ppc@vger.kernel.org, qemu-devel@nongnu.org,
	shivaprasadbhat@gmail.com, qemu-ppc@nongnu.org,
	bharata@linux.vnet.ibm.com, imammedo@redhat.com,
	ehabkost@redhat.com
Subject: Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH
Date: Wed, 31 Mar 2021 03:50:12 +0000	[thread overview]
Message-ID: <87o8f0oud5.fsf@vajain21.in.ibm.com> (raw)
In-Reply-To: <YGO488mqe2RMHBiu@yekko.fritz.box>

Thanks for looking into this patch,

David Gibson <david@gibson.dropbear.id.au> writes:

<snip>
>> H_SCM_HEALTH specifications is already documented in linux kernel
>> documentation at
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst
>
> Putting a reference to that in the commit message would be a good idea.
>
Yes, its already part of v1 patch description as reference [1].

<snip>
>> >
>> > Having access to the excerpts from the PAPR addendum that describes
>> > this hcall would _really_ help in reviewing.
>> >
>> The kernel documentation for H_SCM_HEALTH mentioned above captures most
>> if not all parts of the PAPR addendum for this hcall. I believe it
>> contains enough information to review the patch. If you still need more
>> info than please let me know.
>
> We've missed the qemu-6.0 cutoff, so this will be 6.1 material.  I'll
> await v2 for further review.
>
Agree. Will send a v2 today incorporating current review comments.


-- 
Cheers
~ Vaibhav

  reply	other threads:[~2021-03-31  3:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 16:34 [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH Vaibhav Jain
2021-03-30  6:50 ` Shivaprasad G Bhat
2021-03-30  8:50   ` Vaibhav Jain
2021-03-30 14:14 ` Greg Kurz
2021-03-30 17:19   ` Vaibhav Jain
2021-03-30 23:49     ` David Gibson
2021-03-31  3:50       ` Vaibhav Jain [this message]
2021-03-31  9:15     ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8f0oud5.fsf@vajain21.in.ibm.com \
    --to=vaibhav@linux.ibm.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=shivaprasadbhat@gmail.com \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).