From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabiano Rosas Date: Tue, 11 Jan 2022 14:39:39 +0000 Subject: Re: [PATCH v3 3/6] KVM: PPC: Don't use pr_emerg when mmio emulation fails Message-Id: <87pmoy8hg4.fsf@linux.ibm.com> List-Id: References: <20220107210012.4091153-1-farosas@linux.ibm.com> <20220107210012.4091153-4-farosas@linux.ibm.com> <1641791924.shozt0u4v5.astroid@bobo.none> In-Reply-To: <1641791924.shozt0u4v5.astroid@bobo.none> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nicholas Piggin , kvm-ppc@vger.kernel.org Cc: aik@ozlabs.ru, linuxppc-dev@lists.ozlabs.org Nicholas Piggin writes: > Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: >> If MMIO emulation fails we deliver a Program interrupt to the >> guest. This is a normal event for the host, so use pr_info. >> >> Signed-off-by: Fabiano Rosas >> --- > > Should it be rate limited to prevent guest spamming host log? In the > case of informational messages it's always good if it gives the > administrator some idea of what to do with it. If it's normal > for the host does it even need a message? If yes, then identifying which > guest and adding something like "(this might becaused by a bug in guest > driver)" would set the poor admin's mind at rest. I'll drop this message then and improve the other one that is emitted earlier at the emulation code.