From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabiano Rosas Date: Tue, 17 Aug 2021 22:20:57 +0000 Subject: Re: [PATCH kernel] KVM: PPC: Book3S HV: Make unique debugfs nodename Message-Id: <87pmubu306.fsf@linux.ibm.com> List-Id: References: <20210707041344.3803554-1-aik@ozlabs.ru> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexey Kardashevskiy , Paul Mackerras Cc: linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Alexey Kardashevskiy writes: > On 07/07/2021 14:13, Alexey Kardashevskiy wrote: > alternatively move this debugfs stuff under the platform-independent > directory, how about that? That's a good idea. I only now realized we have two separate directories for the same guest: $ ls /sys/kernel/debug/kvm/ | grep $pid 19062-11 vm19062 Looks like we would have to implement kvm_arch_create_vcpu_debugfs for the vcpu information and add a similar hook for the vm. >> --- >> arch/powerpc/kvm/book3s_hv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c >> index 1d1fcc290fca..0223ddc0eed0 100644 >> --- a/arch/powerpc/kvm/book3s_hv.c >> +++ b/arch/powerpc/kvm/book3s_hv.c >> @@ -5227,7 +5227,7 @@ static int kvmppc_core_init_vm_hv(struct kvm *kvm) >> /* >> * Create a debugfs directory for the VM >> */ >> - snprintf(buf, sizeof(buf), "vm%d", current->pid); >> + snprintf(buf, sizeof(buf), "vm%d-lp%ld", current->pid, lpid); >> kvm->arch.debugfs_dir = debugfs_create_dir(buf, kvm_debugfs_dir); >> kvmppc_mmu_debugfs_init(kvm); >> if (radix_enabled()) >>