From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Date: Fri, 27 Sep 2013 13:20:40 +0000 Subject: Re: [RFC PATCH 08/11] kvm: powerpc: book3s: Support building HV and PR KVM as module Message-Id: <87txh69ztz.fsf@linux.vnet.ibm.com> List-Id: References: <1380276233-17095-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1380276233-17095-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <32B8402B-25D1-41F4-A3FB-B945B72EDC4C@suse.de> In-Reply-To: <32B8402B-25D1-41F4-A3FB-B945B72EDC4C@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org Alexander Graf writes: > On 27.09.2013, at 12:03, Aneesh Kumar K.V wrote: > >> diff --git a/arch/powerpc/kvm/book3s_64_mmu_host.c b/arch/powerpc/kvm/book3s_64_mmu_host.c >> index fd5b393..775d368 100644 >> --- a/arch/powerpc/kvm/book3s_64_mmu_host.c >> +++ b/arch/powerpc/kvm/book3s_64_mmu_host.c >> @@ -27,6 +27,7 @@ >> #include >> #include >> #include >> + > > Stray whitespace change > will fix >> #include "trace_pr.h" >> >> #define PTE_SIZE 12 >> diff --git a/arch/powerpc/kvm/book3s_emulate.c b/arch/powerpc/kvm/book3s_emulate.c >> index b9841ad..20d03c2 100644 >> --- a/arch/powerpc/kvm/book3s_emulate.c >> +++ b/arch/powerpc/kvm/book3s_emulate.c >> @@ -172,7 +172,7 @@ int kvmppc_core_emulate_op_pr(struct kvm_run *run, struct kvm_vcpu *vcpu, >> vcpu->arch.mmu.tlbie(vcpu, addr, large); >> break; >> } >> -#ifdef CONFIG_KVM_BOOK3S_64_PR >> +#ifdef CONFIG_KVM_BOOK3S_PR > > Why? If i have CONFIG_KVM_BOOK3S_64_PR=m #ifdef CONFIG_KVM_BOOK3S_64_PR will not work. There is a runtime check I can use IS_ENABLED(). But didn't want to do those. Hence moved to the symbol which will be set as CONFIG_KVM_BOOK3S_PR = y -aneesh