From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Date: Fri, 04 Jun 2021 00:39:29 +0000 Subject: Re: [RFC][PATCH] kvm: add suspend pm-notifier Message-Id: List-Id: References: <20210603164315.682994-1-senozhatsky@chromium.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Zijlstra Cc: Sergey Senozhatsky , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Marc Zyngier , Huacai Chen , Paul Mackerras , Christian Borntraeger , Suleiman Souhlal , x86@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org On (21/06/03 19:27), Peter Zijlstra wrote: > On Fri, Jun 04, 2021 at 01:43:15AM +0900, Sergey Senozhatsky wrote: [..] > > > > +void kvm_arch_pm_notifier(struct kvm *kvm) > > +{ > > +} > > + > > long kvm_arch_vm_ioctl(struct file *filp, > > unsigned int ioctl, unsigned long arg) > > { > > What looks like you wants a __weak function. True. Thanks for the suggestion. I thought about it, but I recalled that tglx had __strong opinions on __weak functions.