From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Thu, 17 Jun 2021 11:19:50 +0000 Subject: Re: [PATCH v10 3/5] KVM: stats: Add documentation for binary statistics interface Message-Id: List-Id: References: <20210617044146.2667540-1-jingzhangos@google.com> <20210617044146.2667540-4-jingzhangos@google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg KH , Jing Zhang Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan , Fuad Tabba On 17/06/21 08:07, Greg KH wrote: >> The statistics data itself could be read out by userspace telemetry >> periodically without any extra parsing or setup effort. > Do you have a pointer to userspace code that can do such a thing that > others can use? We do not like adding apis to the kernel without at > least seeing the user of those apis, especially for complex things like > this. > > Ideally you would include some library code in the kernel tree itself > that everyone can use for this for their own programs. You have > provided a test which is great, but how do we know it works for "real" > usages? I am pretty sure that Google is using this internally, but we are also going to work on QEMU and Libvirt support for this. As for the rest, thanks for the review---I'll let Jing act on it and only add my own remarks in a couple places. Paolo