From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Date: Fri, 21 Jul 2017 11:32:37 +0000 Subject: Re: [kvm-unit-tests PATCH] powerpc/sprs: Test POWER9 specific registers Message-Id: List-Id: References: <1499929407-29601-1-git-send-email-thuth@redhat.com> <7a00c3e9-685c-ac60-4a83-82cac1347e91@redhat.com> In-Reply-To: <7a00c3e9-685c-ac60-4a83-82cac1347e91@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Vivier , kvm@vger.kernel.org Cc: kvm-ppc@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= On 21.07.2017 13:17, Laurent Vivier wrote: > On 13/07/2017 09:03, Thomas Huth wrote: >> Most of the SPRS are the same as on POWER8, so we can re-use >> the PowerISA 2.07 functions and simply amend the additional >> registers afterwards. >> >> Signed-off-by: Thomas Huth > > Could you explain why you don't add 144 (TIDR)? Good catch. That register was not mentioned in the PowerISA version 3.0 A (from November 30, 2015) which I used when writing this patch. > I don't see 813 and 814 in Power ISA > Version 3.0 B (March 29, 2017). They were mentioned in 3.0 A, but indeed seem to be gone in 3.0 B. I'll update my patch accordingly... Thanks for the review! Thomas