From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Maciej S. Szmigiero" Date: Tue, 09 Nov 2021 00:39:15 +0000 Subject: Re: [PATCH v5.5 06/30] KVM: Use "new" memslot's address space ID instead of dedicated param Message-Id: List-Id: References: <20211104002531.1176691-1-seanjc@google.com> <20211104002531.1176691-7-seanjc@google.com> In-Reply-To: <20211104002531.1176691-7-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Ben Gardon , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Palmer Dabbelt , Paul Walmsley , Albert Ou , Christian Borntraeger , Janosch Frank , Paolo Bonzini On 04.11.2021 01:25, Sean Christopherson wrote: > Now that the address space ID is stored in every slot, including fake > slots used for deletion, use the slot's as_id instead of passing in the > redundant information as a param to kvm_set_memslot(). This will greatly > simplify future memslot work by avoiding passing a large number of > variables around purely to honor @as_id. > > Drop a comment in the DELETE path about new->as_id being provided purely > for debug, as that's now a lie. > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Maciej S. Szmigiero