From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Huth <thuth@redhat.com>
Date: Fri, 13 Oct 2017 09:45:22 +0000
Subject: Re: [RFC kvm-unit-tests PATCH] powerpc: add tests for XICS
Message-Id: <ec8a4d24-dff5-4964-c66b-2df864631616@redhat.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <20171012080704.31037-1-lvivier@redhat.com>
In-Reply-To: <20171012080704.31037-1-lvivier@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Laurent Vivier <lvivier@redhat.com>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>

On 12.10.2017 10:07, Laurent Vivier wrote:
> Check if we can set the xive server and priority, and
> check we get values that have been set.
> Check we disable/enable interrupts.
> 
> This patch also increases NR_CPUS from 8 to 16
> (maximum for KVM on POWER9, POWER8 allows 96)
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> Note: I send this as an RFC, because even if this test works well with
> TCG and POWER8 KVM hosts, it detects some problems with POWER9 KVM hosts

What kind of errors does it detect? Are they expected due to the
different interrupt controllers?

> main(int argc, char **argv)
>  
>  		check_set_time_of_day();
>  
> +	} else if (strcmp(argv[1], "xics") = 0) {
> +

Superfluous empty line?

> +		check_xics();
> +

 Thomas