From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 19 Feb 2020 09:22:58 +0000 Subject: Re: [PATCH v6 21/22] KVM: x86/mmu: Use ranged-based TLB flush for dirty log memslot flush Message-Id: List-Id: References: <20200218210736.16432-1-sean.j.christopherson@intel.com> <20200218210736.16432-22-sean.j.christopherson@intel.com> In-Reply-To: <20200218210736.16432-22-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson , Paolo Bonzini Cc: Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Hello! On 19.02.2020 0:07, Sean Christopherson wrote: > Use the with_address() variant to when performing a TLB flush for a ^^ is it really needed here? > specific memslot via kvm_arch_flush_remote_tlbs_memslot(), i.e. when > flushing after clearing dirty bits during KVM_{GET,CLEAR}_DIRTY_LOG. > This aligns all dirty log memslot-specific TLB flushes to use the > with_address() variant and paves the way for consolidating the relevant > code. > > Note, moving to the with_address() variant only affects functionality > when running as a HyperV guest. > > Cc: Vitaly Kuznetsov > Signed-off-by: Sean Christopherson [...] MBR, Sergei