From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa2-f35.google.com (mail-oa2-f35.google.com [74.125.231.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E7849EC76 for ; Mon, 28 Sep 2026 13:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790603065; cv=none; b=ugjEFY3DjYLm9xhdxu1NBXxwv3yCDM6+0qxlpEf+y3VWJr+Ev6+nk1yaH7C3a/kL12PqaVBTqo2fzfSbYOXpEBizya1udY9Nd3tiQmZpE2bk74ML+DFTny1hV35GSfUPR8M2mSOOy+wGfBTZiTk5H7I0HetJY9Ri0CQWQOYqPQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790603065; c=relaxed/simple; bh=GovrrZN3cHyF7Si62BejyKGqmJUiVqEeTzDNhyu+l7I=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=eu5flDrSwrKdKW1N7RE8MSA56wYF0WJa+xPlIXYyuKpBVWNqi6W8rMOYtxNpCg4dQaTGORDHwakmcMk2ag3rqNsnOyESXx6HPC5dargLReZS50O0pfCudMc83pGUqL/iq6FlaBIdwpXsoJMrQGZfRgcNnTxswC6gP31TXB3pSVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I1mrqWpK; arc=none smtp.client-ip=74.125.231.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I1mrqWpK" Received: by mail-oa2-f35.google.com with SMTP id 586e51a60fabf-493cf6d8e60so1127325fac.3 for ; Mon, 28 Sep 2026 06:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790603062; x=1791207862; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=OqSWB16/v2nKqaGPKDp/hMATqYQmRiJplxi26oO8Rsc=; b=I1mrqWpKIyYVHM2mopl6yYRHDwrulVZbbF6uu3h5rKDvIeTItVCmKw5AUiOksIuCfQ eFEUqz9ZPvzm1t6cQ/NINZilvbKt8uqX5cHtlvg3qznVv0vk0pXDf7/rxVUap6WzWVx9 5w1nMpOt2dG8Ms/7S8ssDdYopIlSJRCDyb7XTLK30Fvp+212CsfCzaDDfqKqI5iGR1sz HFEf0np+OBbXMTBffRsQoGMqYLs9q7HYQkHQWGT1mwrv2MVkVG7TBtSSkFUzk/6QkMIB IguvbvIKZishggAu3DEMhsJ6IZlDBCfCBg4PIqzpbXLYEiXEdsnnW70ZQUy54y+A6/Jh 9pmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790603062; x=1791207862; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OqSWB16/v2nKqaGPKDp/hMATqYQmRiJplxi26oO8Rsc=; b=Go6J6llZWueulaiptWpAzIxt59pggNl7YwSy0nfVRQYIBnkHQ3ynfn4u9VgcCXBpM+ 6aVISIf7bSKQXRRvpovcHsMkVgqEcqkBvJHTiD9Pvcof7I/kvh21r0uL/C/APqtcHb4J riY7g6G3w0A4vfUp9f813QHShFAPW53bm6LoxdZe+5Du4xtYj9zwPEp0vIJF0C6RBvNf lZ5xBHSb+Uva8FFfLRXucuAF3NDA/d9pSabWNNTXRqk8XQugK4FD0MglSKDqljQ91kih UN2GiZb5eIMK2mDbVaIy4iLzDdbRbKZHpkQnceqVRxrIbCEjNfOv6ktlZ87DFq8KnK5q X85A== X-Forwarded-Encrypted: i=1; AKwUvBzaPgTFKedYvQgF5CqCsZQTZH6g3tCFwg9AIq8gXOpf0494tHIvNUGu+9OwGwyKHCZnXAsKyITp@vger.kernel.org X-Gm-Message-State: AFuF++nS3VUlGt1Q00AfK0FK0dxVixNDNlczPO2is6pqXmHlfNWhGbtD YWnoVTnxCYYctKAQLqvD0cGQ/0HrL7LjDOfxQ4e4rYVOnsrYbEHIMhr9 X-Gm-Gg: AYBFou3OPDHdiJp0DSOSTLFeDKz9YtW2iUvx7a/C560rLQ20Zc0f8i5zsC+6xHpIHGn acwpSWYtuKHgDQfB8sUnirq4W615hQ3RLdOktZgM/0pKzHixryrp8dnqaQniLY56DuqUHvaZNk7 v9Hb6jS7YAq+SlfF2GxQCgeezceGnB5EUAtTj7VH3AQwKLWc726bBU2xuRBf7s+zr4kju4ahZfE Bv39DOuv+T9265xH5jaZtHnY8Tp//WGp1jxIAJUjJIiwXtLN3MYwivHTn59qqdWturkSBv0rXGC P5FB0x3I0zmPjGFwp7hx61nmc/iYftwZf1+gsy2QqQoPnFXKM2l469Rv9e3S1iRULsQ73TWpqMP 4//r2VUFd0UN2gni9rdZBUyhHw4GD/JfQ6b5uSVvgNoWmKkiPstY1EUWM6GpKsTNmL7mWV+QZ0I Tr3/DZsicHZWQ4jsbc78So1Pd3JuDwibvj/x+Hca4MZ4lcBKxJRLsHBCzCM7ziMfs94n7dRgewF /2qLorUudLGmlx8qohsl8MzTf2I00ymuXsaYCQgeBPwsV6v4yfnkQ== X-Received: by 2002:a05:6871:eb03:b0:48f:e0f6:c46a with SMTP id 586e51a60fabf-49358a317cfmr9008681fac.56.1790603062123; Mon, 28 Sep 2026 06:44:22 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-493356565b6sm10053356fac.9.2026.09.28.06.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 06:44:21 -0700 (PDT) From: Ritesh Harjani (IBM) To: Amit Machhiwal , Madhavan Srinivasan , linuxppc-dev@lists.ozlabs.org Cc: Amit Machhiwal , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , Shrikanth Hegde , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Gautam Menghani , Harsh Prateek Bora , R Nageswara Sastry , Alexander Graf , linux-hardening@vger.kernel.org, stable@vger.kernel.org, Avi Kivity Subject: Re: [RESEND PATCH 2/3] KVM: PPC: Book3S HV: Add preempt_disable() around virtual-mode HPTE bit-lock users In-Reply-To: <20260928122837.8782-3-amachhiw@linux.ibm.com> Date: Mon, 28 Sep 2026 19:12:53 +0530 Message-ID: References: <20260928122837.8782-1-amachhiw@linux.ibm.com> <20260928122837.8782-3-amachhiw@linux.ibm.com> Precedence: bulk X-Mailing-List: kvm-ppc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Amit Machhiwal writes: > kvmppc_hv_find_lock_hpte() requires virtual-mode callers to run with > preemption disabled, because it can return with HPTE_V_HVLOCK still held > until the caller later unlocks the HPTE. Existing virtual-mode callers > in book3s_64_mmu_hv.c already follow that rule. > That make sense. LGTM. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM)