From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Nazarewicz Date: Wed, 11 Jun 2014 08:24:55 +0000 Subject: Re: [RFC PATCH 2/3] DMA, CMA: use general CMA reserved area management framework Message-Id: List-Id: References: <1401757919-30018-1-git-send-email-iamjoonsoo.kim@lge.com> <1401757919-30018-3-git-send-email-iamjoonsoo.kim@lge.com> <20140610024910.GB19036@js1304-P5Q-DELUXE> In-Reply-To: <20140610024910.GB19036@js1304-P5Q-DELUXE> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Joonsoo Kim Cc: Andrew Morton , "Aneesh Kumar K.V" , Marek Szyprowski , Minchan Kim , Russell King - ARM Linux , Greg Kroah-Hartman , Paolo Bonzini , Gleb Natapov , Alexander Graf , Benjamin Herrenschmidt , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On Tue, Jun 10 2014, Joonsoo Kim wrote: > Without including device.h, build failure occurs. > In dma-contiguous.h, we try to access to dev->cma_area, so we need > device.h. In the past, we included it luckily by swap.h in > drivers/base/dma-contiguous.c. Swap.h includes node.h and then node.h > includes device.h, so we were happy. But, in this patch, I remove > 'include ' so we need to include device.h explicitly. Ack. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------ooO--(_)--Ooo--