KVM-RISCV Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: kvm-riscv@lists.infradead.org
Subject: [kvmtool PATCH v2 6/6] riscv: Fix guest/init linkage for multilib toolchain
Date: Wed, 25 Oct 2023 15:42:22 +0200	[thread overview]
Message-ID: <20231025-58718d04ce00e6ce7bbd4ef2@orel> (raw)
In-Reply-To: <20230918125730.1371985-7-apatel@ventanamicro.com>

On Mon, Sep 18, 2023 at 06:27:30PM +0530, Anup Patel wrote:
> For RISC-V multilib toolchains, we must specify -mabi and -march
> options when linking guest/init.
> 
> Fixes: 2e99678314c2 ("riscv: Initial skeletal support")
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index acd5ffd..d84dc8e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -223,9 +223,11 @@ ifeq ($(ARCH),riscv)
>  	OBJS		+= riscv/aia.o
>  	ifeq ($(RISCV_XLEN),32)
>  		CFLAGS	+= -mabi=ilp32d -march=rv32gc
> +		GUEST_INIT_FLAGS += -mabi=ilp32d -march=rv32gc
>  	endif
>  	ifeq ($(RISCV_XLEN),64)
>  		CFLAGS	+= -mabi=lp64d -march=rv64gc
> +		GUEST_INIT_FLAGS += -mabi=lp64d -march=rv64gc
>  	endif
>  
>  	ARCH_WANT_LIBFDT := y
> -- 
> 2.34.1
>

Looks good and like something that could be posted independently of this
series.

Reviewed-by: Andrew Jones <ajones@ventanamicro.com>

Thanks,
drew


  reply	other threads:[~2023-10-25 13:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 12:57 [kvmtool PATCH v2 0/6] RISC-V AIA irqchip and Svnapot support Anup Patel
2023-09-18 12:57 ` [kvmtool PATCH v2 1/6] Sync-up header with Linux-6.5 for KVM RISC-V Anup Patel
2023-09-18 12:57 ` [kvmtool PATCH v2 2/6] riscv: Add Svnapot extension support Anup Patel
2023-10-25 12:54   ` Andrew Jones
2023-09-18 12:57 ` [kvmtool PATCH v2 3/6] riscv: Make irqchip support pluggable Anup Patel
2023-10-25 13:10   ` Andrew Jones
2023-11-18 12:59     ` Anup Patel
2023-09-18 12:57 ` [kvmtool PATCH v2 4/6] riscv: Add IRQFD support for in-kernel AIA irqchip Anup Patel
2023-10-25 13:17   ` Andrew Jones
2023-11-18 12:59     ` Anup Patel
2023-09-18 12:57 ` [kvmtool PATCH v2 5/6] riscv: Use AIA in-kernel irqchip whenever KVM RISC-V supports Anup Patel
2023-10-25 13:39   ` Andrew Jones
2023-11-18 13:01     ` Anup Patel
2023-09-18 12:57 ` [kvmtool PATCH v2 6/6] riscv: Fix guest/init linkage for multilib toolchain Anup Patel
2023-10-25 13:42   ` Andrew Jones [this message]
2023-10-12  4:20 ` [kvmtool PATCH v2 0/6] RISC-V AIA irqchip and Svnapot support Anup Patel
2023-11-07 11:11   ` Will Deacon
2023-11-18 13:52     ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231025-58718d04ce00e6ce7bbd4ef2@orel \
    --to=ajones@ventanamicro.com \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox