KVM-RISCV Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: kvm-riscv@lists.infradead.org
Subject: [RFC kvm-unit-tests PATCH v2 09/14] shellcheck: Fix SC2145
Date: Sat,  6 Apr 2024 22:38:18 +1000	[thread overview]
Message-ID: <20240406123833.406488-10-npiggin@gmail.com> (raw)
In-Reply-To: <20240406123833.406488-1-npiggin@gmail.com>

  SC2145 (error): Argument mixes string and array. Use * or separate
  argument.

Shouldn't be a bug, since the preceding string ends with a space and
there aren't any succeeding strings.

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arm/efi/run             | 2 +-
 riscv/efi/run           | 2 +-
 scripts/mkstandalone.sh | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arm/efi/run b/arm/efi/run
index f07a6e55c..cf6d34b0b 100755
--- a/arm/efi/run
+++ b/arm/efi/run
@@ -87,7 +87,7 @@ uefi_shell_run()
 if [ "$EFI_DIRECT" = "y" ]; then
 	$TEST_DIR/run \
 		$KERNEL_NAME \
-		-append "$(basename $KERNEL_NAME) ${cmd_args[@]}" \
+		-append "$(basename $KERNEL_NAME) ${cmd_args[*]}" \
 		-bios "$EFI_UEFI" \
 		"${qemu_args[@]}"
 else
diff --git a/riscv/efi/run b/riscv/efi/run
index 982b8b9c4..cce068694 100755
--- a/riscv/efi/run
+++ b/riscv/efi/run
@@ -97,7 +97,7 @@ if [ "$EFI_DIRECT" = "y" ]; then
 	fi
 	$TEST_DIR/run \
 		$KERNEL_NAME \
-		-append "$(basename $KERNEL_NAME) ${cmd_args[@]}" \
+		-append "$(basename $KERNEL_NAME) ${cmd_args[*]}" \
 		-machine pflash0=pflash0 \
 		-blockdev node-name=pflash0,driver=file,read-only=on,filename="$EFI_UEFI" \
 		"${qemu_args[@]}"
diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh
index 86c7e5498..756647f29 100755
--- a/scripts/mkstandalone.sh
+++ b/scripts/mkstandalone.sh
@@ -76,7 +76,7 @@ generate_test ()
 
 	cat scripts/runtime.bash
 
-	echo "run ${args[@]}"
+	echo "run ${args[*]}"
 }
 
 function mkstandalone()
-- 
2.43.0



  parent reply	other threads:[~2024-04-06 12:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-06 12:38 [RFC kvm-unit-tests PATCH v2 00/14] add shellcheck support Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 01/14] Add initial shellcheck checking Nicholas Piggin
2024-04-11  7:03   ` Thomas Huth
2024-04-16  4:35     ` Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 02/14] shellcheck: Fix SC2223 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 03/14] shellcheck: Fix SC2295 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 04/14] shellcheck: Fix SC2094 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 05/14] shellcheck: Fix SC2006 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 06/14] shellcheck: Fix SC2155 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 07/14] shellcheck: Fix SC2143 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 08/14] shellcheck: Fix SC2013 Nicholas Piggin
2024-04-08  7:34   ` Andrew Jones
2024-04-10  4:29     ` Nicholas Piggin
2024-04-06 12:38 ` Nicholas Piggin [this message]
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 10/14] shellcheck: Fix SC2124 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 11/14] shellcheck: Fix SC2294 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 12/14] shellcheck: Fix SC2178 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 13/14] shellcheck: Fix SC2048 Nicholas Piggin
2024-04-06 12:38 ` [RFC kvm-unit-tests PATCH v2 14/14] shellcheck: Suppress various messages Nicholas Piggin
2024-04-08  7:37   ` Andrew Jones
2024-04-15 11:59 ` [RFC kvm-unit-tests PATCH v2 00/14] add shellcheck support Thomas Huth
2024-04-16  3:26   ` Nicholas Piggin
2024-04-16  4:46     ` Thomas Huth
2024-04-17  1:40       ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240406123833.406488-10-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox