From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B2ADC021BE for ; Thu, 27 Feb 2025 08:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XxDG1i1gRwqe6LlF/7l8psV7WgFq5WmTY3JnuzwOOM4=; b=LpT8a12DGa1Jqf eOZQUFWbpsZHgMOXxmLz/jR9Z4u2A0yC3LzABBKpreyK1oFPT3Hosu+xWWXMgkk6WcmDHUXMDjrjC Y4Bw74JUxs30PLBs5seUo45qWkAXOp4akWKUHPybaJvybulsZsIY+eYtCjzeo+ovVWlBvinjwUPwp MCH2DK+whlzKKRggO5MrEDq4rMGe7TnTapAvhWd5Gjy7gOH1/t6Vy3KBS2KdAeiYxFonwDXO1Pw/H HZW/v4DSTvIPh5iNOKiiAhqeok0vkzPy1CQ5wK8zqPTyum53R/pxLZREA6wB2Kp7iBRWTWxQEM+w7 TGMZFbqRGC7M+AEQ9w/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnZaO-00000006lSj-0FPK; Thu, 27 Feb 2025 08:49:40 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnZaM-00000006lRg-1HYC for kvm-riscv@lists.infradead.org; Thu, 27 Feb 2025 08:49:39 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-439ac3216dcso4310175e9.1 for ; Thu, 27 Feb 2025 00:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1740646176; x=1741250976; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8xwt/QS7TwZTYg2MTdoUft0EF5h6WRYVihzhqZrEMa0=; b=Y5FsVQeueZDu3gEiFQHGu7Bv+/DCXsvk0BQk4M9+lZvAYTdPyDD5f+H4fJFT+D9VoQ KA0gDlg1JjPwU5HyCJ9q3yWP7cTc1KhjmZ1Gz4WSnbHkP5/UlxkXXlXAMesOlU8J70Jl TFWT4vRpQ5NNYSDFZ20rsmNxz/Id+B0SCQtKZuNVB9A5jMxs06pfxL8Rd1lX9+lv16T1 mzJhZBYFKWtYLNEixh0gdmNpcTZSLZpf72mI6Ru4GJKK1R0BGZKHiVTw/tki4Yb0RVwm NYd57bmqNbnHk29e9OxUNn4Yeb3AzQkV/VhNFQvgD0GyQuZ1LiNuKVJ65ea54zpvpFbM qZIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740646176; x=1741250976; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8xwt/QS7TwZTYg2MTdoUft0EF5h6WRYVihzhqZrEMa0=; b=wL3gfwyxOW9v8fvTAEKx+HfPdosac8cS511VJoJ2CJZDcJyU87FWZim4yld2pCcMWT 257yKDP3RlmkNISNaD/ZPYLZp9eK50et3APROv6K6JGGduU4BOxShPtl2lYjOSKdRWbZ lruGXWqZmCW6D//fLHGTqs1DPN1q6pu9ze00QtlgBP0c0w/Aa2B7VZHamJ/dFdF/IPsm +062tm4NP4ql/ScXafldqzWxsSgnIZJZ0+QAhGhrW8wVSNFzE5PjjGyX5baZabGY2qkR V8jjIQkoLnP6Me0NlzlJS4SBSNCl+ZMEeHAhq2gW/uKyQRWnyHr37WmfpNxUnhAezsqw uYuw== X-Forwarded-Encrypted: i=1; AJvYcCWj1gDIW4QqUZbRaU3HgJmOzYsYWX6m/IjLUuD2waf/RXpc9I+TKbk+1J1+XtCuIOjVogzbIGqeX7g=@lists.infradead.org X-Gm-Message-State: AOJu0YyMMxse5fR7AR0ctMHWALbsF9tnA060C/s56mQ8QvIdnEW8yuSM pBdjcpxQajZbtLN49s0dJ/IfFhKJjL1RIOC5Irgykn+i94jjSTijHiQYL95CHqE= X-Gm-Gg: ASbGncvxQmbW7Z1P/8Bw6x4N3YSdlpX+kWVVf9EnsJLOSuZwDaBQvhRpLvueGpig+Hh oWSv0x1bDza58ucjZJ9YNDbDc+Nn+S+L6Z1Xv4f8mkFZ1XUL5rEtzMsRw2kxvkrnWg+wiRDy0a+ b3KYFDna+Cu/8YxjUgT50k0/CrEtWqq10A+9Qan2oPZDat2B/aIHc7188Jju6hdeSBvtefzq2vG toNTwBIR+ULJBbu8XddHiGNbLaHDs3bvgNYizv/MZvw39yQfwLd3s4g/P5qjTEnhO0GVGmkeTTN KNz8g0M5xFYKrA== X-Google-Smtp-Source: AGHT+IGsBt36A+nA64K8jmDgdrsH+3epzXLzR2VIcO1N8jO+7h2K8GwaLjrguW+gS8ljkw0FbuPM+w== X-Received: by 2002:a05:600c:4f47:b0:439:8bb3:cf8e with SMTP id 5b1f17b1804b1-439aebc369dmr183762555e9.20.1740646176499; Thu, 27 Feb 2025 00:49:36 -0800 (PST) Received: from localhost ([2a02:8308:a00c:e200::8cf0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47b7c43sm1308781f8f.49.2025.02.27.00.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 00:49:36 -0800 (PST) Date: Thu, 27 Feb 2025 09:49:35 +0100 From: Andrew Jones To: Atish Patra Cc: Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Paolo Bonzini , Shuah Khan , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/4] RISC-V: KVM: Disable the kernel perf counter during configure Message-ID: <20250227-d64f688ee1df2811528ec2b9@orel> References: <20250226-kvm_pmu_improve-v1-0-74c058c2bf6d@rivosinc.com> <20250226-kvm_pmu_improve-v1-1-74c058c2bf6d@rivosinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250226-kvm_pmu_improve-v1-1-74c058c2bf6d@rivosinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250227_004938_348038_DEB843FB X-CRM114-Status: GOOD ( 17.76 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Wed, Feb 26, 2025 at 12:25:03PM -0800, Atish Patra wrote: > The perf event should be marked disabled during the creation as > it is not ready to be scheduled until there is SBI PMU start call > or config matching is called with auto start. Otherwise, event add/start > gets called during perf_event_create_kernel_counter function. > It will be enabled and scheduled to run via perf_event_enable during > either the above mentioned scenario. > > Fixes: 0cb74b65d2e5 ("RISC-V: KVM: Implement perf support without sampling") > > Signed-off-by: Atish Patra > --- > arch/riscv/kvm/vcpu_pmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/kvm/vcpu_pmu.c b/arch/riscv/kvm/vcpu_pmu.c > index 2707a51b082c..78ac3216a54d 100644 > --- a/arch/riscv/kvm/vcpu_pmu.c > +++ b/arch/riscv/kvm/vcpu_pmu.c > @@ -666,6 +666,7 @@ int kvm_riscv_vcpu_pmu_ctr_cfg_match(struct kvm_vcpu *vcpu, unsigned long ctr_ba > .type = etype, > .size = sizeof(struct perf_event_attr), > .pinned = true, > + .disabled = true, > /* > * It should never reach here if the platform doesn't support the sscofpmf > * extension as mode filtering won't work without it. > > -- > 2.43.0 > Reviewed-by: Andrew Jones -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv