From: Andrew Jones <andrew.jones@linux.dev>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: kvm@vger.kernel.org, Shaoqin Huang <shahuang@redhat.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Sean Christopherson <seanjc@google.com>,
kvm-riscv@lists.infradead.org, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 1/2] build: work around secondary expansion limitation with some Make versions
Date: Mon, 8 Sep 2025 13:22:01 -0500 [thread overview]
Message-ID: <20250908-8ebb10e1e917a5befd6b5f44@orel> (raw)
In-Reply-To: <20250908010618.440178-1-npiggin@gmail.com>
Missing the kvm-unit-tests prefix and, for this patch, the riscv prefix.
On Mon, Sep 08, 2025 at 11:06:17AM +1000, Nicholas Piggin wrote:
> GNU Make 4.2.1 as shipped in Ubuntu 20.04 has a problem with secondary
> expansion and variable names containing the '/' character. Make 4.3 and
> 4.4 don't have the problem.
>
> Instead of using the variable name from riscv/sbi-deps and matching it
> from the riscv/sbi.* target name, name the variable sbi-deps and match
> it by stripping the riscv/ directory name off the riscv/sbi.* target
> name.
>
> Reported-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> riscv/Makefile | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Added the riscv prefix while merging.
Thanks,
drew
--
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv
next prev parent reply other threads:[~2025-09-09 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 1:06 [PATCH 1/2] build: work around secondary expansion limitation with some Make versions Nicholas Piggin
2025-09-08 1:06 ` [PATCH 2/2] shellcheck: suppress SC2327,2328 false positives Nicholas Piggin
2025-09-08 18:23 ` Andrew Jones
2025-09-08 18:22 ` Andrew Jones [this message]
2025-09-08 23:23 ` [PATCH 1/2] build: work around secondary expansion limitation with some Make versions Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908-8ebb10e1e917a5befd6b5f44@orel \
--to=andrew.jones@linux.dev \
--cc=alexandru.elisei@arm.com \
--cc=imbrenda@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=seanjc@google.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).