From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD4ACE7719E for ; Mon, 13 Jan 2025 10:17:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rQZ1+6FwUU5cqC/+fIckEFzlBUz2gg1l1svdsOB1yT4=; b=0K7uCYzW/JNnbJ iKqDual/RPGcRcyizY4q6uELtOopzI4LULgaVfYXHuomnJYLgDee1gUAHBPfm851X9fwjIPgagqxV s0OxfBQQbyy1nv3KVhrtoB11nrGsUAkid45mgVm4uNyrubBEYcqRXi6Hvprx893jUdDkITc0uz/Gi 7kFpJ+kdCVf+Ltaiml05ylNAnUb8kemL7ep5wBTU1FD8SKpwTKPUMKv5QQMkmT6pm4+MYiD8M2lJF cAlfdb7JU4K97RlywZCXuNN7/ECO3T8QicFxDuJlMVjr0w4u+InBBiDvuZd6HnkxmFGFUGrKw6oUi TeIY9zg+nDdOAIzrYfSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tXHVg-00000004lSP-1epW; Mon, 13 Jan 2025 10:17:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tXHVe-00000004lRi-2FlI for kvm-riscv@lists.infradead.org; Mon, 13 Jan 2025 10:17:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D9A51424; Mon, 13 Jan 2025 02:17:52 -0800 (PST) Received: from [10.1.28.144] (e121487-lin.cambridge.arm.com [10.1.28.144]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23D0E3F66E; Mon, 13 Jan 2025 02:17:20 -0800 (PST) Message-ID: <44d60dff-ab73-4d10-9110-c5c2ddebadf6@arm.com> Date: Mon, 13 Jan 2025 10:17:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [kvm-unit-tests PATCH v1 0/5] arm64: Change the default --processor to max To: Alexandru Elisei , andrew.jones@linux.dev, eric.auger@redhat.com, lvivier@redhat.com, thuth@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, nrb@linux.ibm.com, david@redhat.com, pbonzini@redhat.com Cc: kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250110135848.35465-1-alexandru.elisei@arm.com> Content-Language: en-GB From: Vladimir Murzin In-Reply-To: <20250110135848.35465-1-alexandru.elisei@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250113_021726_624768_3B554109 X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On 1/10/25 13:58, Alexandru Elisei wrote: > (CC'ing everyone from MAINTAINERS because I'm touching configure) > > Vladimir sent a test for MTE [1], which didn't work on the default -cpu > model, cortex-a57, because that CPU didn't implement MTE. There were two > options to get it working: > > 1. Add -cpu max to the extra_params unittest parameter. > 2. Make the default value for the configure --processor option 'max'. > > We decided that the second option was preferable, so here it is. > > The first patch might look unrelated, but when I was writing the function > to select the default processor based on the architecture I noticed that > for arm64, $arch is first equal to aarch64, then it gets changed to arm64. > My first instinct was to have it be arm64 from the start, but then I > realized that, despite the help text, --arch=aarch64 has been supported > ever since arm64 was added to kvm-unit-tests. So I decided that it might > more prudent to go with it and document it. > > [1] https://lore.kernel.org/all/20241212103447.34593-1-vladimir.murzin@arm.com/ > Thanks Alex! That removes extra hassle of setting up -cpu to match required feature. My MTE test continue working fine and require one less configuration option - undeniable improvement in user experience! FWIW: Tested-by: Vladimir Murzin # arm64 Vladimir > Alexandru Elisei (5): > configure: Document that the architecture name 'aarch64' is also > supported > configure: Display the default processor for arm and arm64 > arm64: Implement the ./configure --processor option > arm/arm64: Add support for --processor=max > configure: arm64: Make 'max' the default for --processor > > arm/Makefile.arm | 1 - > arm/Makefile.common | 3 +++ > configure | 35 ++++++++++++++++++++++++++--------- > 3 files changed, 29 insertions(+), 10 deletions(-) > > > base-commit: 0ed2cdf3c80ee803b9150898e687e77e4d6f5db2 > -- 2.47.1 > -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv