kvm-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Shaoqin Huang <shahuang@redhat.com>
To: kvm-riscv@lists.infradead.org
Subject: [PATCH v6 10/11] KVM: arm64: Invalidate the table entries upon a range
Date: Tue, 18 Jul 2023 19:17:26 +0800	[thread overview]
Message-ID: <a8a43069-ca4c-07e6-3b65-de749f295365@redhat.com> (raw)
In-Reply-To: <20230715005405.3689586-11-rananta@google.com>



On 7/15/23 08:54, Raghavendra Rao Ananta wrote:
> Currently, during the operations such as a hugepage collapse,
> KVM would flush the entire VM's context using 'vmalls12e1is'
> TLBI operation. Specifically, if the VM is faulting on many
> hugepages (say after dirty-logging), it creates a performance
> penalty for the guest whose pages have already been faulted
> earlier as they would have to refill their TLBs again.
> 
> Instead, leverage kvm_tlb_flush_vmid_range() for table entries.
> If the system supports it, only the required range will be
> flushed. Else, it'll fallback to the previous mechanism.
> 
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Shaoqin Huang <shahuang@redhat.com>
> ---
>   arch/arm64/kvm/hyp/pgtable.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c
> index 5d14d5d5819a..5ef098af1736 100644
> --- a/arch/arm64/kvm/hyp/pgtable.c
> +++ b/arch/arm64/kvm/hyp/pgtable.c
> @@ -806,7 +806,8 @@ static bool stage2_try_break_pte(const struct kvm_pgtable_visit_ctx *ctx,
>   		 * evicted pte value (if any).
>   		 */
>   		if (kvm_pte_table(ctx->old, ctx->level))
> -			kvm_call_hyp(__kvm_tlb_flush_vmid, mmu);
> +			kvm_tlb_flush_vmid_range(mmu, ctx->addr,
> +						kvm_granule_size(ctx->level));
>   		else if (kvm_pte_valid(ctx->old))
>   			kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu,
>   				     ctx->addr, ctx->level);

-- 
Shaoqin



  reply	other threads:[~2023-07-18 11:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-15  0:53 [PATCH v6 00/11] KVM: arm64: Add support for FEAT_TLBIRANGE Raghavendra Rao Ananta
2023-07-15  0:53 ` [PATCH v6 01/11] KVM: Rename kvm_arch_flush_remote_tlb() to kvm_arch_flush_remote_tlbs() Raghavendra Rao Ananta
2023-07-17  8:03   ` Philippe Mathieu-Daudé
2023-07-17 11:06   ` Shaoqin Huang
2023-07-15  0:53 ` [PATCH v6 02/11] KVM: arm64: Use kvm_arch_flush_remote_tlbs() Raghavendra Rao Ananta
2023-07-17  8:12   ` Philippe Mathieu-Daudé
2023-07-17 16:28     ` Raghavendra Rao Ananta
2023-07-17 11:27   ` Shaoqin Huang
2023-07-15  0:53 ` [PATCH v6 03/11] KVM: Allow range-based TLB invalidation from common code Raghavendra Rao Ananta
2023-07-17 11:40   ` Shaoqin Huang
2023-07-17 16:37     ` Raghavendra Rao Ananta
2023-07-18  2:49       ` Shaoqin Huang
2023-07-18 16:31         ` Raghavendra Rao Ananta
2023-07-15  0:53 ` [PATCH v6 04/11] KVM: Move kvm_arch_flush_remote_tlbs_memslot() to " Raghavendra Rao Ananta
2023-07-18  2:47   ` Shaoqin Huang
2023-07-15  0:53 ` [PATCH v6 05/11] arm64: tlb: Refactor the core flush algorithm of __flush_tlb_range Raghavendra Rao Ananta
2023-07-18  6:21   ` Shaoqin Huang
2023-07-15  0:54 ` [PATCH v6 06/11] KVM: arm64: Implement __kvm_tlb_flush_vmid_range() Raghavendra Rao Ananta
2023-07-18  7:50   ` Shaoqin Huang
2023-07-18 16:39     ` Raghavendra Rao Ananta
2023-07-15  0:54 ` [PATCH v6 07/11] KVM: arm64: Define kvm_tlb_flush_vmid_range() Raghavendra Rao Ananta
2023-07-18  8:39   ` Shaoqin Huang
2023-07-15  0:54 ` [PATCH v6 08/11] KVM: arm64: Implement kvm_arch_flush_remote_tlbs_range() Raghavendra Rao Ananta
2023-07-18 11:15   ` Shaoqin Huang
2023-07-15  0:54 ` [PATCH v6 09/11] KVM: arm64: Flush only the memslot after write-protect Raghavendra Rao Ananta
2023-07-18 11:17   ` Shaoqin Huang
2023-07-15  0:54 ` [PATCH v6 10/11] KVM: arm64: Invalidate the table entries upon a range Raghavendra Rao Ananta
2023-07-18 11:17   ` Shaoqin Huang [this message]
2023-07-15  0:54 ` [PATCH v6 11/11] KVM: arm64: Use TLBI range-based intructions for unmap Raghavendra Rao Ananta
2023-07-15  2:02 ` [PATCH v6 00/11] KVM: arm64: Add support for FEAT_TLBIRANGE Raghavendra Rao Ananta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8a43069-ca4c-07e6-3b65-de749f295365@redhat.com \
    --to=shahuang@redhat.com \
    --cc=kvm-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).