From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD711C83F17 for ; Wed, 9 Jul 2025 23:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oZKLoURMTW/trdWT6RQVV92dtV/JhCn2KFllszwTgxc=; b=LDn7TS8+dXC0vG 4p77LwOPyh0F6cqC8vMYaBl8ZzUEP0pA9gGPAzSToGVO10+bkK5UJew3ks7WaZaTq5R4SeYPb3STJ fDdQJ1FyKkKSYXlvPMT4s1jteYwCq+I6WXE6kYdyjbk3EHEnifT0Qkmdr/86MUj2SmjddP3nGQfr9 T0K5StBOs2q/N/dHWdTR2tNvd+sUPlBmKwU+q+hwVqRgGCngaYCmef/Pri5Sc+bMmm7kbVFAHVpmk OBfaPf5vi18F1p8DjPtMC59rHkzRuYN8Kzrb4PNmWm+8Ew6qmDKc9cmJEa5eMxy1+EgQouHwtG5CP e7GwZiz71SKB0MkplmXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZdub-0000000AEBm-1AUK; Wed, 09 Jul 2025 23:09:13 +0000 Received: from out-172.mta1.migadu.com ([95.215.58.172]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZduY-0000000AE5Y-1Fm1 for kvm-riscv@lists.infradead.org; Wed, 09 Jul 2025 23:09:11 +0000 Date: Wed, 9 Jul 2025 16:06:38 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1752102420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uvZFJjtA5QE9squ61CMyH0mvqvsYVZ05/N0Uv4JADjk=; b=RK16oQUaJcuPz5AF68IuE7tQUp6ad9ibGnITlKl/Od0JZw4bYJVbJwqR85jQ3zRAvFVCuc Tw8axMHzy1q9Wxb9q84OuW2sz6Dxmm+/fPSX0mSRX0syd0d0rt1VMoo+v6Gpd187TwTy4s RxGdW+l2TZ2WF3Qqow76CYR3gGrJI2k= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Vipin Sharma Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, seanjc@google.com, pbonzini@redhat.com, anup@brainfault.org, borntraeger@linux.ibm.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, maz@kernel.org, dmatlack@google.com Subject: Re: [PATCH v2 11/15] KVM: selftests: Auto generate default tests for KVM Selftests Runner Message-ID: References: <20250606235619.1841595-1-vipinsh@google.com> <20250606235619.1841595-12-vipinsh@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250606235619.1841595-12-vipinsh@google.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250709_160910_570388_464F39C1 X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Fri, Jun 06, 2025 at 04:56:15PM -0700, Vipin Sharma wrote: > Add logic in Makefile.kvm to auto generate default test files for KVM > Selftests Runner. Preserve the hierarchy of test executables for > autogenerated files. > > Autogeneration of default test files guards against missing these files > for new tests cases or rename of existing ones. These autogenerated > files will be checked in so that during git-diff one can easily identify > if the existing test files for the same test binary also needs an > update. It also add new tests automatically in the default coverage. I'm not sure I'm sold on the merits of committing these to the tree. My preference would be to prioritize signal to noise and just commit the 'interesting' test configurations and generate the defaults from $(TEST_PROGS) somewhere they're gitignored. There's no amount of foolproofing that'll prevent folks from renaming a test name w/o updating the 'interesting' test configurations that depend upon it. Seriously -- I'm sure I'll manage to break it at least once :) On top of that, there's a lot of selftests that take no arguments. Not sure what we gain having a duplicated definition for these ones outside of $(TEST_PROGS). Thanks, Oliver -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv