From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Huth <thuth@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] [RFC] run: add -nodefaults
Date: Wed, 16 Nov 2016 02:51:35 +0100
Message-ID: <0028722f-1870-e396-45e8-e72235d50929@redhat.com>
References: <1479232047-22195-1-git-send-email-drjones@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: rkrcmar@redhat.com, pbonzini@redhat.com, lvivier@redhat.com
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58502 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751981AbcKPBvj (ORCPT <rfc822;kvm@vger.kernel.org>);
        Tue, 15 Nov 2016 20:51:39 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id AA8B880F8E
        for <kvm@vger.kernel.org>; Wed, 16 Nov 2016 01:51:38 +0000 (UTC)
In-Reply-To: <1479232047-22195-1-git-send-email-drjones@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 15.11.2016 18:47, Andrew Jones wrote:
> Adding pci-test to arm allowed us to see that a virtio-net-pci
> device was getting added to our machine by default. Unit tests
> should configure the most minimal machines they can, only adding
> devices necessary for the tests. Let's add -nodefaults to all
> the run scripts.
> 
> I tested all arches (powerpc and arm on tcg). There were no
> unexpected changes.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  arm/run     | 2 +-
>  powerpc/run | 2 +-
>  x86/run     | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arm/run b/arm/run
> index 1ee6231599d6..f1b04af614dc 100755
> --- a/arm/run
> +++ b/arm/run
> @@ -73,7 +73,7 @@ if $qemu $M -device '?' 2>&1 | grep pci-testdev > /dev/null; then
>  fi
>  
>  M+=",accel=$ACCEL"
> -command="$qemu $M -cpu $processor $chr_testdev $pci_testdev"
> +command="$qemu -nodefaults $M -cpu $processor $chr_testdev $pci_testdev"
>  command+=" -display none -serial stdio -kernel"
>  command="$(timeout_cmd) $command"
>  echo $command "$@"
> diff --git a/powerpc/run b/powerpc/run
> index 14988a75b1e2..afdd487bfc35 100755
> --- a/powerpc/run
> +++ b/powerpc/run
> @@ -43,7 +43,7 @@ fi
>  
>  M='-machine pseries'
>  M+=",accel=$ACCEL"
> -command="$qemu $M -bios $FIRMWARE"
> +command="$qemu -nodefaults $M -bios $FIRMWARE"
>  command+=" -display none -serial stdio -kernel"
>  command="$(timeout_cmd) $command"
>  echo $command "$@"

For the powerpc part:
Acked-by: Thomas Huth <thuth@redhat.com>