From: Pavel Fedin <p.fedin@samsung.com>
To: 'Christoffer Dall' <christoffer.dall@linaro.org>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
'Peter Maydell' <peter.maydell@linaro.org>,
'Marc Zyngier' <marc.zyngier@arm.com>,
'Andre Przywara' <andre.przywara@arm.com>
Subject: RE: [PATCH v4 3/7] KVM: arm/arm64: Fix the documentation
Date: Thu, 08 Oct 2015 09:52:02 +0300 [thread overview]
Message-ID: <002f01d10195$d6961550$83c23ff0$@samsung.com> (raw)
In-Reply-To: <20151007200439.GC14315@cbox>
Hello!
> > --- a/Documentation/virtual/kvm/devices/arm-vgic.txt
> > +++ b/Documentation/virtual/kvm/devices/arm-vgic.txt
> > @@ -44,28 +44,29 @@ Groups:
> > Attributes:
> > The attr field of kvm_device_attr encodes two values:
> > bits: | 63 .... 40 | 39 .. 32 | 31 .... 0 |
> > - values: | reserved | cpu id | offset |
> > + values: | reserved | cpu idx | offset |
>
> why should this be changed to cpu idx?
Because it's index (from 0 to N - 1), and "cpu id" may confuse readers that it should be MPIDR
affinity value. In register access function we do "vcpu = kvm_get_vcpu(dev->kvm, cpuid);" (see here:
http://lxr.free-electrons.com/source/virt/kvm/arm/vgic-v2-emul.c#L664), and kvm_get_vcpu just
indexes the array: http://lxr.free-electrons.com/source/include/linux/kvm_host.h#L427
I decided to change this after http://www.spinics.net/lists/kvm-arm/msg16359.html, Andre clearly
mistook this ID for being affinity value.
Before GICv3 nobody saw the difference because we had only up to 16 CPUs, with IDs from 0 to 15, i.
e. corresponding to indexes.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-08 6:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 15:27 [PATCH v4 0/7] KVM: arm64: Implement API for vGICv3 live migration Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 1/7] KVM: arm/arm64: Move endianness conversion out of vgic_attr_regs_access() Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 2/7] KVM: arm/arm64: Refactor vGIC attributes handling code Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 3/7] KVM: arm/arm64: Fix the documentation Pavel Fedin
2015-10-07 20:04 ` Christoffer Dall
2015-10-08 6:52 ` Pavel Fedin [this message]
2015-10-08 8:24 ` Christoffer Dall
2015-10-12 7:16 ` Pavel Fedin
2015-10-12 11:56 ` Christoffer Dall
2015-09-28 15:27 ` [PATCH v4 4/7] KVM: arm64: Implement vGICv3 distributor and redistributor access from userspace Pavel Fedin
2015-10-07 20:07 ` Christoffer Dall
2015-09-28 15:27 ` [PATCH v4 5/7] KVM: arm64: Refactor system register handlers Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 6/7] KVM: arm64: Introduce find_reg_by_id() Pavel Fedin
2015-09-28 15:27 ` [PATCH v4 7/7] Implement vGICv3 CPU interface access Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01d10195$d6961550$83c23ff0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=andre.przywara@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).