From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Marc Zyngier' <marc.zyngier@arm.com>,
'Andre Przywara' <andre.przywara@arm.com>,
kvmarm@lists.cs.columbia.edu, 'kvm-devel' <kvm@vger.kernel.org>
Subject: RE: [PATCH v5 0/7] KVM: arm64: Implement API for vGICv3 live migration
Date: Wed, 28 Oct 2015 15:24:06 +0300 [thread overview]
Message-ID: <008601d1117b$8a995810$9fcc0830$@samsung.com> (raw)
In-Reply-To: <CAFEAcA_SpUa9Czk4=95h-0RpHTBKVVf8CkX_5S7XOO7kt7at-Q@mail.gmail.com>
Hello!
> > v4 => v5:
> > - Adapted to new API by Peter Maydell, Marc Zyngier and Christoffer Dall.
> > Acked-by's on the documentation were dropped, just in case, because i
> > slightly adjusted it. Additionally, i merged all doc updates into one
> > patch.
>
> Could you tell us what you changed in the doc patch from the version
> that got sent out with the acks, please?
Sorry, completely forgot to answer this one...
The major differences / things to review are:
1. Both GICv2 and GICv3 use the same value of KVM_DEV_ARM_VGIC_CPUID_MASK, which is extended to 32 bits. So GICv2 attribute layout also looks like:
--- cut ---
bits: | 63 .... 32 | 31 .... 0 |
values: | vcpu_index | offset |
--- cut ---
2. KVM_DEV_ARM_VGIC_CPU_SYSREGS documentation originally says (error code description):
--- cut ---
-EBUSY: One or more VCPUs are running
--- cut ---
While my version says "VCPU is running". Since this is CPU interface, it does not affect other CPUs, so for simplicity i check only current vCPU in my code.
That's all. Just i'm maybe too careful about fundamentals...
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
prev parent reply other threads:[~2015-10-28 12:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 8:29 [PATCH v5 0/7] KVM: arm64: Implement API for vGICv3 live migration Pavel Fedin
2015-10-12 8:29 ` [PATCH v5 1/7] KVM: arm/arm64: Move endianess conversion out of vgic_attr_regs_access() Pavel Fedin
2015-10-12 8:29 ` [PATCH v5 2/7] KVM: arm/arm64: Refactor vGIC attributes handling code Pavel Fedin
2015-10-12 8:29 ` [PATCH v5 3/7] KVM: arm64: Implement vGICv3 distributor and redistributor access from userspace Pavel Fedin
2015-10-12 8:29 ` [PATCH v5 4/7] KVM: arm64: Refactor system register handlers Pavel Fedin
2015-10-12 8:29 ` [PATCH v5 5/7] KVM: arm64: Introduce find_reg_by_id() Pavel Fedin
2015-10-12 8:29 ` [PATCH v5 6/7] KVM: arm64: Implement vGICv3 CPU interface access Pavel Fedin
2015-10-12 8:29 ` [PATCH v5 7/7] KVM: arm/arm64: Update API documentation Pavel Fedin
2015-10-23 14:20 ` [PATCH v5 0/7] KVM: arm64: Implement API for vGICv3 live migration Peter Maydell
2015-10-28 12:24 ` Pavel Fedin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008601d1117b$8a995810$9fcc0830$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).